Bug 652571 (ghc-digest)
| Summary: | Review Request: ghc-digest - cryptographic hashes of bytestrings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Narasimhan <lakshminaras2002> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, haskell-devel, lakshminaras2002, notting |
| Target Milestone: | --- | Flags: | lakshminaras2002:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-digest-0.0.0.8-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-20 21:58:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 652573 | ||
|
Description
Jens Petersen
2010-11-12 09:00:14 UTC
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.
rpmlint -i ghc-digest.spec ghc-digest-0.0.0.8-1.fc14.i686.rpm ghc-digest-0.0.0.8-1.fc14.src.rpm ghc-digest-devel-0.0.0.8-1.fc14.i686.rpm ghc-digest-prof-0.0.0.8-1.fc14.i686.rpm
ghc-digest.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-digest.i686: W: spelling-error %description -l en_US bytestrings -> byte strings, byte-strings, shoestrings
The value of this tag appears to be misspelled. Please double-check.
ghc-digest.i686: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
The value of this tag appears to be misspelled. Please double-check.
ghc-digest.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-digest.src: W: spelling-error %description -l en_US bytestrings -> byte strings, byte-strings, shoestrings
The value of this tag appears to be misspelled. Please double-check.
ghc-digest.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
The value of this tag appears to be misspelled. Please double-check.
ghc-digest-devel.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-digest-devel.i686: W: spelling-error %description -l en_US bytestrings -> byte strings, byte-strings, shoestrings
The value of this tag appears to be misspelled. Please double-check.
ghc-digest-devel.i686: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
The value of this tag appears to be misspelled. Please double-check.
ghc-digest-prof.i686: E: devel-dependency ghc-digest-devel
Your package has a dependency on a devel package but it's not a devel package
itself.
ghc-digest-prof.i686: W: spelling-error %description -l en_US bytestrings -> byte strings, byte-strings, shoestrings
The value of this tag appears to be misspelled. Please double-check.
ghc-digest-prof.i686: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
The value of this tag appears to be misspelled. Please double-check.
ghc-digest-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
ghc-digest-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/digest-0.0.0.8/libHSdigest-0.0.0.8_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
4 packages and 1 specfiles checked; 1 errors, 13 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK, BSD 2 clause variant
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - present anyway. OK
%clean is ignored - present anyway. OK
Build Requires list - OK, only c dependencies
Summary and description - OK
API documentation - OK, present in devel package
[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
BSD two clause variant
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
[~] md5sum digest-0.0.0.8.tar.gz
3a730a6439b14fb7a30bcd03c9e3f4ff digest-0.0.0.8.tar.gz
[~] md5sum ~/Downloads/digest-0.0.0.8.tar.gz
3a730a6439b14fb7a30bcd03c9e3f4ff ~/Downloads/digest-0.0.0.8.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on i686 http://koji.fedoraproject.org/koji/taskinfo?taskID=2596521
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
checked with rpmquery --whatprovides.
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
checked with rpmlint and ls -lR
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-digest
error: Failed dependencies:
ghc-digest = 0.0.0.8-1.fc14 is needed by (installed) ghc-digest-devel-0.0.0.8-1.fc14.i686
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[+]MUST: Packages must not own files or directories already owned by other packages.
checked with rpmquery --list and rpmquery --whatprovides
[+]MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the package on i686. Wrote a small program to import the module Data.Digest.Adler32. Compiled and ran it. No issues.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.
cabal2spec-diff is OK.
APPROVED.
Thanks for the review. :) New Package SCM Request ======================= Package Name: ghc-digest Short Description: Haskell hash digest library Owners: petersen Branches: f13 f14 InitialCC: haskell-sig Git done (by process-git-requests). Built in koji. ghc-digest-0.0.0.8-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-digest-0.0.0.8-1.fc14 ghc-digest-0.0.0.8-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ghc-digest-0.0.0.8-1.fc13 ghc-digest-0.0.0.8-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ghc-digest'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ghc-digest-0.0.0.8-1.fc13 ghc-digest-0.0.0.8-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. ghc-digest-0.0.0.8-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: ghc-digest New Branches: el6 Owners: petersen InitialCC: haskell-sig Git done (by process-git-requests). |