Bug 653545

Summary: spice client log shows incorrect information regarding secure/insecure channels
Product: Red Hat Enterprise Linux 6 Reporter: Ortal <ogvura>
Component: spice-clientAssignee: Christophe Fergeau <cfergeau>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: low Docs Contact:
Priority: low    
Version: 6.0CC: alevy, cfergeau, cmeadors, cpelland, dblechte, djasa, jrb, lkocman, mkenneth, ogvura, syeghiay, uril, ykaul
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: spice-client-0.8.2-1.el6 Doc Type: Bug Fix
Doc Text:
Cause Connection to spice-server secure_port is done by securing (using openssl) an unsecured connection (established using connect_unsecure function). Consequence Spice client log showed secure-connection messages containing "connect_unsecure" Fix The function that establish connection was renamed to connect_to_peer. Both secure and unsecure connections call this function. Result Spice client log shows secure-connection messages containing "connect_to_pee r" and does not contain "unsecure".
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 15:22:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch rediffed against git master none

Description Ortal 2010-11-15 17:05:34 UTC 
Description of problem:

The log shows that the connection is unsecured instead of secured.

Version-Release number of selected component (if applicable):

[ogvura@ogvura ~]$ rpm -q spice-client
spice-client-0.6.3-2.el6_0.3.x86_64
[ogvura@ogvura ~]$ rpm -q spice-xpi
spice-xpi-2.4-1.el6.x86_64


Steps to Reproduce:
1. Connect to the VM via spicec
2. Run the command: cat .spicec/spicec.log
  
Actual results:
 
Getting the Error print: (RedPeer::connect_unsecure: Trying 10.35.64.95 5885 )

Expected results:

Changing the error to be secured.
Comment 2 Yaniv Kaul 2010-11-15 19:16:14 UTC 
Ortal, please attach complete log.

The problem is that the connection (2 out of the 6 or so channels) are actually TLS secured. Nevertheless, all the logs are connection_*unsecure*
Comment 3 Ortal 2010-11-16 07:52:22 UTC 
**Please see attached Logs.
Comment 4 Jonathan Blandford 2010-12-01 22:47:36 UTC 
We should investigate this.  dev_acking.
Comment 5 Alon Levy 2011-01-03 12:55:02 UTC 
Ortal,

 Can you attach the logs?

Thanks!
Comment 6 Uri Lublin 2011-03-29 16:11:32 UTC 
The patch:
http://lists.freedesktop.org/archives/spice-devel/2011-February/002413.html
Comment 11 Christophe Fergeau 2011-07-04 16:46:13 UTC 
It looks like the patch mentioned in this bug hasn't been applied yet, even though it was ACK'ed on the mailing list. I think this bug should be devel_ack+ and the patch committed to spice git.
Comment 12 Christophe Fergeau 2011-07-08 11:38:01 UTC 
Created attachment 511912 [details]
patch rediffed against git master
Comment 15 Christophe Fergeau 2011-07-18 16:38:08 UTC 
The patch from comment #12 has been pushed to spice git master
Comment 16 Christophe Fergeau 2011-07-28 10:38:48 UTC 
This bug is fixed in spice 0.8.2 which is being pushed to RHEL 6.2
Comment 18 David Jaša 2011-10-14 14:21:52 UTC 
VERIFIED in spice-client-0.8.2-7:

1318595180 INFO [16959:16960] RedPeer::connect_unsecure: Connected to 10.34.58.4 5904
1318595180 INFO [16959:16960] RedPeer::connect_secure: Connected to 10.34.58.4 5905
Comment 19 Uri Lublin 2011-11-20 11:02:11 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    Connection to spice-server secure_port is done by securing (using openssl) an unsecured connection (established using connect_unsecure function).
Consequence
    Spice client log showed secure-connection messages containing "connect_unsecure"
Fix
    The function that establish connection was renamed to connect_to_peer. Both secure and unsecure connections call this function.
Result
    Spice client log shows secure-connection messages containing "connect_to_pee
r" and does not contain "unsecure".
Comment 20 errata-xmlrpc 2011-12-06 15:22:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1518.html