Bug 654151
| Summary: | Review Request: sizzle - JavaScript CSS selector engine | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steven Garcia <webwhammy> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | msuchy, package-review, pahan, petersen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | AwaitingSubmitter | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-21 13:06:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Steven Garcia
2010-11-17 01:43:56 UTC
Here is the link to Source1: Conf URL: http://aikiframework.org/files/sizzle/sizzle.conf Here are some reference notes for anyone interested in reviewing this package (sizzle). A JavaScript library similar in packaging was approved and has existed in Fedora for quite a while. The name of the package is MochiKit which can be seen here http://pkgs.fedoraproject.org/gitweb/?p=MochiKit.git;a=tree. Here is a link to the approved review https://bugzilla.redhat.com/show_bug.cgi?id=176528. Using rpmlint update as specified here: https://fedoraproject.org/wiki/Packaging/Guidelines#Use_rpmlint Ran successful rpmlint on spec, srpm, rpm and installed rpm $ rpmlint sizzle \ SPECS/sizzle.spec \ SRPMS/sizzle-1.4.4-1.fc13.src.rpm \ RPMS/noarch/sizzle-1.4.4-1.fc13.noarch.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Here's an unofficial review for F15,
+ rpmlint output
rpmlint output is silent
[makerpm@dhcp201-181 SRPMS]$ rpmlint sizzle-1.4.4-1.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ Package Naming Guidelines
* Spec file name is sizzle.spec and name in spec file is "sizzle" which is okie
+ Licenses mentioned in the spec file are "MIT or BSD or GPLv2" which looks okie
+ Used global variables in the spec file which is good
+ Sepc file is in American English
+ Installed the package into the system following files are getting updated onto the system
/usr/share/sizzle
/usr/share/doc/sizzle-1.4.4
/etc/httpd/conf.d/
I'm just looking over some old review tickets. While in principle this package seems simple, the amazingly excessive macro usage makes the spec nearly unreadable. The whole spec should be on the order of 20 lines. I'd be willing to give you a package review, but only if you're willing to do something reasonably simple. If you insist on that horribly verbose style you're using now, I don't think I can help you. Closing due long inactivity. Feel free to reopen if you want to continue. |