Bug 654443

Alex, can you review?

Ok, I'll do it. 
Btw, the review flag is smth the reviewer should set

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
h2-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese
not a problem
h2-javadoc.noarch: W: invalid-license EPL 1.0
h2.noarch: W: invalid-license EPL 1.0
Please use the standard short names of the licences
h2.noarch: W: no-documentation
not a problem

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[!]  Package successfully compiles and builds into binary rpms.
see http://koji.fedoraproject.org/koji/getfile?taskID=2608459&name=build.log
[x]  Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: EPL
[!]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
there is doc/html/license.html file which should be installed as doc
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[x]  Package consistently uses macros.
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[-]  If package contains pom.xml files install it (including depmaps) even when building with ant 
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[!]  Reviewer should test that the package builds in mock.



=== Issues ===
1. Fix license tag.
2. Fix compile.
3. Install license as doc in both main and javadoc subpackage.
4. Drop dependency on main package in javadoc.

"4. Drop dependency on main package in javadoc"

What does this mean?

"Requires:       %{name} = %{version}-%{release}" line should be gone because javadoc is perfectly usable without the jar.

Ok, uploaded new changes, passes koji scratch build :)

http://koji.fedoraproject.org/koji/taskinfo?taskID=2611564

Spec URL: http://aniszczyk.org/misc/h2/h2.spec
SRPM URL: http://aniszczyk.org/misc/h2/h2-1.2.145-1.fc14.src.rpm

3. Install license as doc in BOTH main and javadoc subpackage. is still not fixed

Please use servlet25 (tomcat6) unless you are going to spend time on tomcat5 maintainership.

Uploaded new change with Alex's suggested changes.

Spec URL: http://aniszczyk.org/misc/h2/h2.spec
SRPM URL: http://aniszczyk.org/misc/h2/h2-1.2.145-1.fc14.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=2619046

Thanks, 
This package is APPROVED.

P.S. Please submit the 2 patches upstream.

Thanks Alex!

New Package SCM Request
=======================
Package Name: h2
Short Description: Java SQL database
Owners: caniszczyk
Branches: f14
InitialCC: caniszczyk

Git done.

In rawhide now...