Bug 654746
| Summary: | add gnome3 support, make default browser work again for xdg-settings | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> | ||||||||
| Component: | xdg-utils | Assignee: | Rex Dieter <rdieter> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | rawhide | CC: | dwmw2, mcepl, mcepl, pertusus, rdieter, rosenstand, tbzatek, walters | ||||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-02-01 15:25:59 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 617261 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bastien Nocera
2010-11-18 18:13:46 UTC
Note that this is needed for Chromium to detect whether it's the default browser or not. In order to upstream this patch, wouldn't we need to make it able to detect GNOME 2.32 vs 3 and choose the right one? Any sh snippet advice on how to detect gnome3? (and is this change specific to gnome3)? (In reply to comment #3) > Any sh snippet advice on how to detect gnome3? (and is this change specific to > gnome3)? It's GNOME3 specific, so this is what we'll need in Fedora going forward (from F15 onwards). Created attachment 461430 [details]
updated patch
Fixes xdg-settings check not working as expected (we were comparing a desktop name to a binary one).
(In reply to comment #2) > In order to upstream this patch, wouldn't we need to make it able to detect > GNOME 2.32 vs 3 and choose the right one? Right, it seems that the upstream isn't as dead as I thought and Rex is a committer, so I should fix it up. Created attachment 461442 [details]
new patch
Adds the ability to detect GNOME 3.x, on its own, and also ports the mailto functionality to x-scheme-handler.
I also tested the GNOME3 code path more thoroughly for the browser settings, and it works as expected on the command-line, and when used in chromium ("check" to detect the current browser, and "set" to set chromium as the default browser).
Any news on this? Thanks for the poke, I'll work on this today. Patch upstreamed (with some minor fuzz), http://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=6f49c05ceb2a1935d07c49c2e100b5cf3cdf5f26 and snapshot build xdg-utils-1.1.0-0.2.20110201.fc15 submitted, http://koji.fedoraproject.org/koji/taskinfo?taskID=2754753 Not sure if this needs to be re-opened or if it's a new issue, but the functionality is broken in xdg-utils-1.1.0-0.6.20110505.fc15.noarch. [mark@thinkpad ~]$ xdg-settings get default-web-browserwhich: no gnome-default-applications-properties in (/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/mark/bin) which: no gnome-default-applications-properties in (/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/mark/bin) google-chrome.desktop [mark@thinkpad ~]$ /opt/google/chrome/xdg-settings get default-web-browser which: no gnome-default-applications-properties in (/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/mark/bin) google-chrome.desktop Chrome will use the system supplied one if available, and it keeps asking me if it can be the default. I've tried both stable (Chrome 12) and unstable (Chrome 14) and both fail. As an aside, why is which(1) stderr output redirected to stdout? I think the Chromium guys figured it out. Please pick up the change from here: http://code.google.com/p/chromium/issues/detail?id=89258#c4 Filed a separate bug: https://bugzilla.redhat.com/show_bug.cgi?id=721188 |