Bug 654939

Summary:	Publican ignores format attribute in imagedata
Product:	[Community] Publican	Reporter:	Laura Bailey <lbailey>
Component:	publican	Assignee:	Ruediger Landmann <rlandman+disabled>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	2.3	CC:	anross, jfearn, jmorgan, mmcallis, publican-list, rlandman
Target Milestone:	3.0	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-10-31 03:11:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Laura Bailey 2010-11-19 05:12:11 UTC

When parsing the following:
<imagedata fileref="http://www.someurl.com/picture.png?attribute=value" />
Publican tries to use the last three characters of the fileref ("lue") as the file extension. This is expected.

However, even if format="PNG" is added to the imagedata tag, Publican still uses "lue".


Version-Release number of selected component (if applicable):
publican-2.3-0.fc13.noarch


Expected results:
Publican should use the contents of the format attribute to determine filetype.

Comment 1 Jeff Fearn 🐞 2010-11-21 22:30:52 UTC

There is no reason for Publican to be setting this attribute at all, removed code that sets format attribute.

Fixed in build: 2.3-0%{?dist}.t21

Comment 2 Andrew Ross 2010-11-22 03:40:12 UTC

works for format="PNG"
fails for format="png" (as expected, case sensitive)

works for example in comment#0

Comment 3 Jeff Fearn 🐞 2010-12-08 03:49:24 UTC

Publican 2.4 has shipped with a fix for this issue.

Comment 4 Jared MORGAN 2011-01-10 04:46:42 UTC

If you do not specify format="SVG" as an attribute of SVG <imagedata> elements, the SVG image does not appear.  

Rudi recommended that I reopen this issue for further action.

PNG images do not seem to be affected.

Comment 5 Jeff Fearn 🐞 2012-03-12 01:14:47 UTC

This should be fixed in master branch.