Bug 655132

Summary: URLs with a colon in them are not interpreted correctly for Open Link
Product: Red Hat Enterprise Linux 6 Reporter: Jonathan Billings <jsbillin>
Component: gnome-terminalAssignee: Tomáš Bžatek <tbzatek>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: low Docs Contact:
Priority: low    
Version: 6.0CC: jsbillin, pkovar, tpelka, tsmetana
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-terminal-2.31.3-7.el6 Doc Type: Bug Fix
Doc Text:
Previously, the regular expression used to find URLs in the text was missing a colon character. As a consequence, the URL containing a colon was not interpreted correctly. With this update, a colon character has been added to the regular expression so that the URL is now properly interpreted.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-18 06:44:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed patch none

Description Jonathan Billings 2010-11-19 17:18:07 UTC 
Description of problem:
When a URL is viewed in a gnome-terminal, you can right-click on it and select Open Link.  I noticed today when reading the fedora announce mailing list that the following URL doesn't get interpreted correctly:

https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir

When I go to right-click on the URL, it only underlines under the URL up to and including the final colon.  When I select Open Link, it only opens up "https://fedoraproject.org/wiki/Packaging:" in my web browser, and if I choose Copy Link Address, it only copies the same broken URL.  

On my RHEL5 system, this did not occur.  Something must have changed in the URL parser from RHEL5 to RHEL6.

Version-Release number of selected component (if applicable):
gnome-terminal-2.31.3-4.el6.x86_64

How reproducible:
For every URL with a colon in the path part of the URL.

Steps to Reproduce:
1. Start gnome-terminal
2. type any URL with a colon in the path part of the URL (for example:  http://foo.bar/path/with/a/colon:foo )
3. Hover over the URL, and right-click on the URL.
  
Actual results:
Only selects the URL up to and including the colon

Expected results:
Select the entire URL.

Additional info:
Tested on my Fedora 14 system as well, and this behaviour is the same as in RHEL6.
Comment 2 Tomáš Bžatek 2011-01-27 14:26:52 UTC 
Created attachment 475608 [details]
proposed patch

Proposed patch. Since it's a regexp, I can't really think of what else would it break. Running full regression test suite recommended.
Comment 3 Tomáš Bžatek 2011-01-27 14:56:35 UTC 
Filed upstream bug https://bugzilla.gnome.org/show_bug.cgi?id=640727, I'd rather wait for upstream reply before pushing to RHEL.
Comment 9 Tomáš Bžatek 2011-08-01 12:18:00 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: the regexp used to find URLs in text was missing a colon character

Consequence: the URL containing a colon doesn't get interpreted correctly

Fix: a colon character has been added in the regexp

Result: the URL now gets interpreted correctly
Comment 10 Petr Kovar 2011-08-03 13:16:57 UTC 
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,7 +1 @@
-Cause: the regexp used to find URLs in text was missing a colon character
+Previously, the regular expression used to find URLs in the text was missing a colon character. As a consequence, the URL containing a colon was not interpreted correctly. With this update, a colon character has been added to the regular expression so that the URL is now properly interpreted.-
-Consequence: the URL containing a colon doesn't get interpreted correctly
-
-Fix: a colon character has been added in the regexp
-
-Result: the URL now gets interpreted correctly
Comment 11 errata-xmlrpc 2011-08-18 06:44:10 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-1172.html