Bug 655156
Summary: | JON241: deleting a user caused user's modified groups/manually added resources to be inaccessible | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Charles Crouch <ccrouch> |
Component: | Resource Grouping | Assignee: | Lukas Krejci <lkrejci> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Corey Welton <cwelton> |
Severity: | medium | Docs Contact: | |
Priority: | high | ||
Version: | 4.0.0 | CC: | ccrouch, hbrock, jshaughn, mazz, rtimaniy, sdharane |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 622491 | Environment: | |
Last Closed: | 2011-05-24 01:07:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 622491 | ||
Bug Blocks: | 616081 |
Description
Charles Crouch
2010-11-19 18:23:37 UTC
Mazz, Is this going to be "safe" change for 2.4.1 with respect to it needing a dbupgrade step? Is that going to conflict with the dbupgrade steps we will use in 3.0? What happens if we have a 2.4.2 that needs another dbupgrade step? if we have 2.4.2 that adds db upgrade steps, this might conflict. we obviously need to take care here. I think 2.4.2 isn't going to be a problem since it's still going to be based on the release-3.0.0 codebase. The problem is going to be an upgrade from JON 2.4.(1..n) to JON 3.0 which is going to be based on the current master because we are going to have to separate versions wanting to do the same upgrade step. release-3.0.0 is currently on db version 2.91, master is way up with the fixes we want ported over being versions 2.93.1, 2.93.2 and 2.93.3. What I think we need here is to change the version numbers of those changes to 2.92.x both in master and in release-3.0.0 (changing the 2.92 in master to 2.93). This is going to ensure that if a user running JON 2.4.1 upgrades to JON-3.0 we are going to run all the upgrade steps. The fix for this consists of one commit in the release-3.0.0 branch (the one JON 2.4.1 will be created from) and one commit in master branch to put the schemaSpecs in both branches in line so that future db upgrades succeed. commit in release-3.0.0: commit d3a2144aee4c47331cf6fb9e479f5cdce843a466 Author: Lukas Krejci <lkrejci> Date: Tue Nov 23 15:22:25 2010 +0100 BZ 655156 - cherrypick of commit f6409557d36ab77f8baa69cb4dc4d11c5fedc39c with merged in changes from commit 7a1accc180497bc215e3e416a0f19c74f6dc1647 which in effect pulls the fix of BZ 622491 from master to release-3.0.0 branch. The schemaSpec versions in db-upgrade.xml differ from the original commit so that the db-upgrade.xml has linear sequence of updates. The db-upgrade.xml in the master branch has been updated to conform with these new version numbers so that db upgrades from release-3.0.0 to master succeed. Original commit message of BZ 622491 fix: BZ 622491 - do not have subject ID foreign key in "modifiedBy" columns - we only log usernames this prevents errors when someone deletes a user. change RHQ_RESOURCE and RHQ_RESOURCE_GROUP to have VARCHAR modifiedBy rather than integer. This also fixes db-upgrade so existing data can be upgraded. commit in master: commit 1a5836ad1eb746d2273de564aaa0be9f0132e6af Author: Lukas Krejci <lkrejci> Date: Tue Nov 23 15:11:06 2010 +0100 BZ 655156 - putting the db version numbers in line between release-3.0.0 and master branches. Tested with jon-server-2.4.1-SNAPSHOT build# ae99b5b for steps mentioned above. No exception is thrown @ step 10. I don't see subject ID either for doomed. Marking this bug as verified. Bookkeeping - closing bug - fixed in recent release. |