Bug 655496
| Summary: | Review Request: cambozola - A viewer for multipart jpeg streams | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cédric OLIVIER <cedric.olivier> |
| Component: | Package Review | Assignee: | Mat Booth <mat.booth> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mat.booth:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | cambozola-0.92-2.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-29 17:25:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 654052 | ||
|
Description
Cédric OLIVIER
2010-11-21 11:46:06 UTC
the links are unreachable I don't understand, links are reachable for me. I have done an update with last release 0.92. SPEC URL : http://cedric.olivier.free.fr/rpms/cambozola-0.92-1/cambozola.spec SRPM URL : http://cedric.olivier.free.fr/rpms/cambozola-0.92-1/cambozola-0.92-1.fc13.src.rpm Thanks, the links are working now. First remark : did you test if this package works with gcj ? I have tested it with gcj, it works ... but frame rate is very low. I can take this review. Ok, a quick look shows the following needs to be corrected:
* Licence is incorrect, it should be GPLv2+ according the distributed licence and source file headers.
* Unless you plan on participating in EPEL5, the BuildRoot tag is obsolete. EPEL6+ and Fedora 10+ ignore it entirely and it may be removed.
* There is no require for "Requires: %{name}" in the javadoc sub-package. This should be removed.
* In the recently approved new Java guidelines, we no longer should be shipping versioned jars or javadocs, so please drop the symlinks and install everything without the %{version} suffix.
* A %clean section containing only "rm -rf $RPM_BUILD_ROOT" is no longer needed (except perhaps if you intend on participating in EPEL5) and should be removed
* Please reduce the spelling errors that rpmlint complains about where you can. Change "javadocs" to "javadoc" and change "cheesey" to "cheesy". The rest really should be in the dictionary, so I'm willing to overlook them.
Also, if you wish you may put the accent aigu "é" in your name in the change log -- you are allowed to submit UTF-8 encoded spec files. :-)
BTW, if you remove the BuildRoot tag, you may ignore the rpmlint warning "no-buildroot-tag." SPEC URL : http://cedric.olivier.free.fr/rpms/cambozola-0.92-2/cambozola.spec SRPM URL : http://cedric.olivier.free.fr/rpms/cambozola-0.92-2/cambozola-0.92-2.fc13.src.rpm Licence is now corrected. For EPEL5 participation, I don't know. actually cambozola is only used in zoneminder package which is a camera monitoring and analysis tool, it should be a good idea to make zoneminder available for EPEL. Is it possible to leave the BuildRoot tag ? Removed unneeded requires in javadoc section. According to Java packaging guidelines version removed from jar file name. Remove clean section. Reduce the spelling errors in description. (In reply to comment #8) > For EPEL5 participation, I don't know. actually cambozola is only used in > zoneminder package which is a camera monitoring and analysis tool, it should be > a good idea to make zoneminder available for EPEL. Is it possible to leave the > BuildRoot tag ? > Yes, that is fine. Also leave in the %clean section, as EPEL5 also needs that, so make sure that gets added back before you request an EPEL5 branch. :-) I don't see anything else wrong with this package, so it is: APPROVED! New Package SCM Request ======================= Package Name: cambozola Short Description: A viewer for multipart jpeg streams Owners: cquad Branches: F-13 F-14 InitialCC: cquad Git done (by process-git-requests). cambozola-0.92-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/cambozola-0.92-2.fc14 cambozola-0.92-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/cambozola-0.92-2.fc13 cambozola-0.92-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cambozola'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/cambozola-0.92-2.fc14 cambozola-0.92-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. cambozola-0.92-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: cambozola New Branches: el6 Owners: cquad Git done (by process-git-requests). |