Bug 655844

Summary:	krfb: bundled libvncserver
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	krfb	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	21	CC:	alekcejk, jreznik, kevin, ltinkl, rdieter, rnovacek, smparrish, than
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-04 15:43:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	990278

Description Rex Dieter 2010-11-22 14:22:25 UTC

As of kdenetwork-4.5.80, libvncserver code is bundled, here's the upstream commit message:

Import a fork of libvncserver 0.9.7.

This is currently required to be able to split off the event processing code
in small functions so that it is possible to integrate libvncserver's event
loop code with Qt's event loop properly. This is also what vino does; the whole
event loop integration idea was taken from there.

:(

Comment 1 Jaroslav Reznik 2010-11-29 12:43:11 UTC

That means we need en exception from FESCo to ship bundled library. Was an exception granted for vino? Is it possible to reuse vino's bundled libvncserver for krfb (it can be packaged than and used by these two apps).

Comment 2 Rex Dieter 2011-01-09 13:33:07 UTC

looks like 4.5.95 no longer includes this. yay.

Comment 3 Kevin Kofler 2011-01-09 21:42:57 UTC

Huh? I just checked the current 4.6 branch, it's still there.

Comment 4 Kevin Kofler 2011-01-09 21:44:51 UTC

Still there in trunk as well.

Unfortunately, that fork is there to stay. If we want to use the system libvncserver, we need to fork/patch krfb.

Comment 5 Rex Dieter 2011-01-09 21:45:16 UTC

I didn't see it in kdenetwork-4.5.95 tarball

(as a matter of fact, the krdc/vnc support was lacking because BR: libvncserver-devel was missing)

Comment 6 Rex Dieter 2011-01-09 21:46:06 UTC

ok, lame.

libvncserver is there for krfb, krdc needs/uses system libvncserver

Comment 7 Fedora End Of Life 2013-04-03 20:18:04 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 8 Rex Dieter 2014-08-04 02:47:37 UTC

%changelog
* Sun Aug 03 2014 Rex Dieter <rdieter> 4.13.3-2
- krfb: unbundle libvncserver (CVE-2014-4607, #655844)

Comment 9 Rex Dieter 2014-08-04 15:43:54 UTC

libvncserver-0.9.10-0.4.20140718git9453be42.fc21 includes krfb-related patches, and krfb uses that in f21+

Was a little nervous backporting more than that.