Bug 656154

Summary: Fix disk space estimation errors in livecd-iso-to-disk
Product: [Fedora] Fedora Reporter: Frederick Grose <fgrose>
Component: livecd-toolsAssignee: Brian Lane <bcl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj, wtogami
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-16 00:54:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix disk space estimation and reporting code
none
Fix incomplete rename of freespace variable
none
Detect more disk space issues none

Description Frederick Grose 2010-11-23 06:17:10 UTC
Created attachment 462241 [details]
Fix disk space estimation and reporting code

The patch submitted addresses the following:

1. The estimates of disk space to-be-deleted and to-be-added ignored the /syslinux and /EFI/boot folders (typically ~13 MiB on F-14 Live Desktop).

2. If the --skipcompression install option was selected, the compressed size of ext3fs.img was reported (underestimating the installed size by ~975 MiB).

3. The command to estimate free space on the target device could fail if a 'newline' ever crept into the mountpoint name (not likely since the script checks that it is unmounted first).

4. The requested and available space report could be formatted for easier reading.

The patch does not consider or change any of the DVD or net installer code.

The EFI or multi code paths were NOT tested.

Comment 1 Frederick Grose 2010-12-02 04:53:24 UTC
Created attachment 464161 [details]
Fix incomplete rename of freespace variable

I neglected to update a few uses of a renamed variable.  This patch should fix it.

Comment 2 Frederick Grose 2011-03-08 22:24:33 UTC
Created attachment 483049 [details]
Detect more disk space issues

Trap an inappropriate --skipcompress request for an oversized ext3fs.img on VFAT-formatted devices.

Include /boot/olpc.fth in install size estimate for --xo option.