Bug 656190
| Summary: | Review Request: drupal6-pathauto - The Pathauto module automatically generates path aliases | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Borsa <peter.borsa> |
| Component: | Package Review | Assignee: | Volker Fröhlich <volker27> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, volker27 |
| Target Milestone: | --- | Flags: | volker27:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | drupal6-pathauto-1.5-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-29 06:59:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Borsa
2010-11-23 07:50:32 UTC
Updated files: http://asrob.fedorapeople.org/SOURCES/drupal6-pathauto.spec http://asrob.fedorapeople.org/SOURCES/drupal6-pathauto-1.5-1.fc14.src.rpm rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-pathauto.spec ../SRPMS/drupal6-pathauto-1.5-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2637132 Watching tasks (this may be safely interrupted)... 2637132 build (dist-f14, drupal6-pathauto-1.5-1.fc14.src.rpm): open (x86-20.phx2.fedoraproject.org) 2637133 buildArch (drupal6-pathauto-1.5-1.fc14.src.rpm, noarch): free 2637133 buildArch (drupal6-pathauto-1.5-1.fc14.src.rpm, noarch): free -> open (x86-15.phx2.fedoraproject.org) 2637133 buildArch (drupal6-pathauto-1.5-1.fc14.src.rpm, noarch): open (x86-15.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2637132 build (dist-f14, drupal6-pathauto-1.5-1.fc14.src.rpm): open (x86-20.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2637132 build (dist-f14, drupal6-pathauto-1.5-1.fc14.src.rpm) completed successfully Please correct the license to GPLv2+, as all modules hosted in Drupal's CVS must be. http://asrob.fedorapeople.org/SOURCES/drupal6-pathauto.spec http://asrob.fedorapeople.org/SOURCES/drupal6-pathauto-1.5-2.fc14.src.rpm Fixed. [+] Good [x] Needs work [0] Does not apply MUST: ===== [+] rpmlint: [makerpm@fedora13 rpmbuild]$ rpmlint SRPMS/drupal6-pathauto-1.5-2.fc13.src.rpm RPMS/noarch/drupal6-pathauto-1.5-2.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [+] Naming according to the Package Naming Guidelines [+] Spec file matches base package name [+] Packaging guidelines met [+] License approved for Fedora [+] License field in spec matches code [+] License file included, if source package includes it [+] Spec in American English [+] Spec is legible [+] Sources match upstream md5sum: bc18f8e88b71c55b130cc21fcfc4ce0e [+] Compiles and builds into binary RPMs on at least one primary architecture: http://koji.fedoraproject.org/koji/taskinfo?taskID=2742412 [0] ExcludeArch is specified and commented [+] Locales are handled correctly [0] All build dependencies listed [0] Calls ldconfig for its shared libraries [0] No bundled system libraries [0] Stated as relocatable package [+] Owns all its directories or requires package that does [+] No file listing duplicates [+] File permissions correct [+] Consistent use of macros [+] Code or permissible content [0] Large documentation in -doc subpackage [+] No runtime dependency of files listed as %doc [0] Header files in -devel subpackage [0] Static files in -static subpackage [0] Library files without suffix in -devel subpackage [0] Devel-package requires base package [0] No .la libtool archives [0] GUI application includes properly installed %{name}.desktop file [+] No files or directories owned, that other packages own [+] Filenames in packages are UTF-8 SHOULD: ======= [0] Query upstream if no license text is included [+] Package builds in mock: Rawhide [?] Package works as described -- Haven't tried [0] Scriptlets are sane, if used [0] Subpackages other than -devel should require base package (versioned) [0] pkgconfig files in -devel subpackage [0] Dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself [0] Contain man pages, where they make sense -------- APPROVED -------- New Package SCM Request ======================= Package Name: drupal6-pathauto Short Description: Automatically generates path aliases Owners: asrob Branches: f14 el5 el6 InitialCC: Git done (by process-git-requests). drupal6-pathauto-1.5-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drupal6-pathauto-1.5-2.el5 drupal6-pathauto-1.5-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-pathauto-1.5-2.el6 drupal6-pathauto-1.5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/drupal6-pathauto-1.5-2.fc14 drupal6-pathauto-1.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository. drupal6-pathauto-1.5-2.el5 has been pushed to the Fedora EPEL 5 stable repository. |