Bug 656363
| Summary: | Review Request: perl-Package-Stash-XS - Faster and more correct implementation of the Package::Stash API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Package-Stash-XS-0.17-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-06 17:01:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul Howarth
2010-11-23 15:40:56 UTC
+ source files match upstream.
5430594809936af4add03e627c43a42a Package-Stash-XS-0.17.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text included
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=2643009
+ package installs properly.
+ rpmlint has no complaints:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(Package::Stash::XS) = 0.17
perl-Package-Stash-XS = 0.17-2.fc15
perl-Package-Stash-XS(x86-64) = 0.17-2.fc15
=
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
perl(:MODULE_COMPAT_5.12.2)
perl(strict)
perl(warnings)
perl(XSLoader)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rtld(GNU_HASH)
+ %check is present and all tests pass.
t/00-compile.t ............ ok
t/01-basic.t .............. ok
t/02-extension.t .......... ok
t/03-io.t ................. ok
t/04-get.t ................ ok
t/05-isa.t ................ ok
t/06-addsub.t ............. ok
t/07-edge-cases.t ......... ok
t/10-synopsis.t ........... ok
t/20-leaks.t .............. ok
t/21-leaks-debug.t ........ ok
t/release-eol.t ........... ok
t/release-no-tabs.t ....... ok
t/release-pod-coverage.t .. ok
t/release-pod-syntax.t .... ok
All tests successful.
Files=15, Tests=297, 1 wallclock secs ( 0.06 usr 0.02 sys + 0.54 cusr 0.06 csys = 0.68 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
The patches for EPEL are necessary and applied sanely.
APPROVED.
New Package SCM Request ======================= Package Name: perl-Package-Stash-XS Short Description: Faster and more correct implementation of the Package::Stash API Owners: pghmcfc Branches: f13 f14 el4 el5 el6 InitialCC: perl-sig Git done (by process-git-requests). perl-Package-Stash-XS-0.17-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Package-Stash-XS-0.17-2.fc13 perl-Package-Stash-XS-0.17-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Package-Stash-XS-0.17-2.fc14 perl-Package-Stash-XS-0.17-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Package-Stash-XS-0.17-2.el4 perl-Package-Stash-XS-0.17-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. perl-Package-Stash-XS-0.17-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. perl-Package-Stash-XS-0.17-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Package-Stash-XS-0.17-2.el5 perl-Package-Stash-XS-0.17-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Package-Stash-XS'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Package-Stash-XS-0.17-2.el5 perl-Package-Stash-XS-0.17-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. perl-Package-Stash-XS-0.17-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |