Bug 657502

Summary: virt-inspector depends on EPEL package perl-String-ShellQuote but does not require it
Product: Red Hat Enterprise Linux 6 Reporter: Jinxin Zheng <jzheng>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: medium    
Version: 6.1CC: dallan, mshao
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libguestfs-1.7.17-3.el6 Doc Type: Bug Fix
Doc Text:
The virt-inspector package had an unnecessary dependency on the <package>perl-String-ShellQuote</package> package. This superfluous dependency has been removed. Note that this bug was reported and corrected during development. It was not seen in production systems in the field.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 11:44:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jinxin Zheng 2010-11-26 09:45:41 UTC
Description of problem:
virt-inspector needs (but does not require) perl-String-ShellQuote which is only found in EPEL.

Version-Release number of selected component (if applicable):
libguestfs-tools-1.6.2-4.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. erase perl-String-ShellQuote if you have it installed, and then install libguestfs-tools.

2.
$ virt-inspector --help
Can't locate String/ShellQuote.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /usr/bin/virt-inspector line 30.
BEGIN failed--compilation aborted at /usr/bin/virt-inspector line 30.


Additional info:
virt-inspector2 does not have such problem.

Comment 1 Jinxin Zheng 2010-11-26 09:51:02 UTC
I can only find the perl-String-ShellQuote file in EPEL:

http://download.fedora.redhat.com/pub/epel/beta/6/x86_64/repoview/perl-String-ShellQuote.html

So please add it to RHEL or eliminate the need of it.

Comment 2 Richard W.M. Jones 2010-11-26 10:08:33 UTC
Yes, this is a bug too.

I fixed this for virt-make-fs, but forgot that virt-inspector
(old version) was also using String::ShellQuote.

Comment 3 Richard W.M. Jones 2010-11-30 18:47:30 UTC
https://brewweb.devel.redhat.com/buildinfo?buildID=150467

Comment 4 Jinxin Zheng 2011-01-06 03:25:37 UTC
$ rpm -q libguestfs-tools
libguestfs-tools-1.7.17-4.el6.x86_64

$ virt-inspector
virt-inspector: no image or VM names given
Usage:
     virt-inspector [--connect URI] domname

     virt-inspector guest.img [guest.img ...]

So we have VERIFIED that the String::ShellQuote problem is no longer present.

Comment 9 Laura Bailey 2011-04-20 04:40:52 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
The virt-inspector package had an unnecessary dependency on the <package>perl-String-ShellQuote</package> package. This superfluous dependency has been removed.

Note that this bug was reported and corrected during development. It was not seen in production systems in the field.

Comment 10 errata-xmlrpc 2011-05-19 11:44:46 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0586.html

Comment 11 errata-xmlrpc 2011-05-19 13:10:46 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0586.html