Bug 657529

Summary:	Review Request: conkeror - Keyboard-driven, extensible web browser
Product:	[Fedora] Fedora	Reporter:	Karel Klíč <kklic>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, rvokal
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-07-13 09:11:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karel Klíč 2010-11-26 11:08:31 UTC

Spec URL: http://kklic.fedorapeople.org/conkeror.spec
SRPM URL: http://kklic.fedorapeople.org/conkeror-0.9.3-1.gite282ee4c66.fc13.src.rpm
Description:
Conkeror is a keyboard-driven web browser based on Mozilla
XULRunner. It is easily customizable and extensible in
Javascript. Default keybindings are based on Emacs. Conkeror is
self-documenting, featuring an interactive help system.

$ rpmlint *src.rpm 
conkeror.src: W: spelling-error %description -l en_US customizable -> customization, customize, customable
conkeror.src: W: strange-permission conkeror.sh 0775
conkeror.src: W: no-cleaning-of-buildroot %clean
conkeror.src: W: no-buildroot-tag
conkeror.src: W: no-%clean-section
conkeror.src: W: invalid-url Source0: conkeror-0.9.3-e282ee4c66.tar.gz
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

- rpmlint run on F12, buildroot and %clean warnings are not relevant on F13+
- invalid-url is ok, because we checkout a git repo, no official releases are 
  currently available

$ rpmlint conkeror-debuginfo-0.9.3-1.gite282ee4c66.fc13.i386.rpm conkeror-0.9.3-1.gite282ee4c66.fc13.i386.rpm
conkeror.i386: W: spelling-error %description -l en_US customizable -> customization, customize, customable
conkeror.i386: W: hidden-file-or-dir /usr/share/conkeror/components/.autoreg
conkeror.i386: W: no-manual-page-for-binary conkeror
conkeror.i386: W: no-manual-page-for-binary conkeror-spawn-helper
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

- IMHO man pages can be written later, when the project will be more 
  stable/mature

Comment 1 Jason Tibbitts 2012-04-24 23:19:42 UTC

This seems interesting.  A couple of comments:

Release: does not follow the guidelines for post-release snapshot packages.  Specifically, it is mandatory that you include the date (YYYYMMDD) before the "git" bit.  It's also quite outdated.

It doesn't work for me at all on F16:
  hippogriff:~> conkeror
  Error: Platform version '11.0' is not compatible with
  minVersion >= 1.8.9999
  maxVersion <= 2.*

Various bits of the spec are not required:
  first line of %install (since you're obviously not targeting EL5)
  %defattr line in %files

I guess you're using the complicated %files list on purpose instead of just having %{_datadir}/%{name}/.  That's up to you but it seems a good bit if unnecessary verbiage.

Comment 2 Jason Tibbitts 2012-04-26 19:03:11 UTC

Since it doesn't appear that this has much chance of working on any Fedora release right now, I'll go ahead and market as not ready for review.  Please clear the whiteboard if providing an updated package.

Comment 3 Karel Klíč 2012-07-13 09:11:18 UTC

I do not use Conkeror anymore.