Bug 657548

Summary: unable to clone channel with a channelname that begins with a number/digit
Product: Red Hat Satellite 5 Reporter: Paresh Mutha <pmutha>
Component: WebUIAssignee: Tomas Lestach <tlestach>
Status: CLOSED ERRATA QA Contact: Martin Minar <mminar>
Severity: medium Docs Contact:
Priority: medium    
Version: 540CC: cperry, jhutar, mkoci, mminar, xdmoon
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spacewalk-java-1.2.39-55 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-17 02:30:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 677501    

Description Paresh Mutha 2010-11-26 12:39:28 UTC
Description of problem:
Unable to clone a channel if the cloned channel name begins with a digit, but I able to rename the channel name to a name that begins with a number/digit.

Please make it uniform, either allow channelnames with number as first sign or do not allow it when changing name on a channel. 

Version-Release number of selected component (if applicable):
Red Hat Network Satellite v5.4.0

How reproducible:
Always

Steps to Reproduce:
1. Channels -> Manage Software Channels -> Clone Channel -> select any existing channel -> Clone channel
2. Enter the name starting with digit
3. Create Channel
  
Actual results:
Fails with "Invalid channel name '123Clone of 9-custom-software' - must be at least 6 characters long and no longer than 256 characters, begin with a letter, and contain only letters, digits, spaces, '-', ' / ', '_' and '.'"

Expected results:
No Error.

Additional info:
Description on the page says " Channel name and label are required. They each must be at least 6 characters in length. Labels must begin with a letter, contain only lowercase letters, hyphens ('-'), periods ('.'), underscores ('_'), and numerals. Channel name may also contain spaces and forward slashes ('/'). "

So as we have not mentioned channel name should begin with letter, channel name should be accepted which starts with a digit.

Comment 2 Tomas Lestach 2011-02-18 15:52:12 UTC
Yes, we definitely have to unify that. But we want to keep the documentation as is, so I just changed the channel name java regexp according to the original perl ones.

Current behavior:
                       begins with         other allowed chars
 - channel name:       a-zA-Z              alphanumeric whitespace - . ' ( ) / _
 - channel label:      a-z number          alphanumeric(lowecase) - . _

spacewalk.git: 90d6a08a7a26ae7188b4f1f636963706237e5095

Comment 3 Tomas Lestach 2011-02-21 17:24:25 UTC
fix CreateCommandTest.testVerifyChannelName test

spacewalk.git: 5f639d6df1d18db406d16990ebf14f3c0d1530ae

Comment 7 Šimon Lukašík 2011-06-03 09:31:54 UTC
Verified in stage with spacewalk-java-1.2.39-82

Reproducer:
 * Channel creation on webui
 * Clone of channel on webui
 * Rename channel on webui
 * channel.software.create
 * channel.software.clone

A use of a channel_name starting with digit, results in exception.

Comment 8 Clifford Perry 2011-06-17 02:30:27 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

https://rhn.redhat.com/errata/RHSA-2011-0879.html