Bug 658344

Summary: system-config-lvm leaves mount for logical group in fstab after group was completely removed.
Product: [Fedora] Fedora Reporter: John Griffiths <fedora.jrg01>
Component: system-config-lvmAssignee: Marek Grac <mgrac>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: low    
Version: 14CC: agk, dwysocha, itamar, mbroz, mclasen, mgrac, prockai
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: system-config-lvm-1.1.16-1.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 722895 (view as bug list) Environment:
Last Closed: 2011-08-09 01:26:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 722895    
Attachments:
Description Flags
Proposed patch none

Description John Griffiths 2010-11-30 03:45:37 UTC 
Description of problem:
system-config-lvm leaves mount for logical group in fstab after group was completely removed. The devices are removed from /dev/mapper,/dev/disk but the entry for mounting the group is left in /etc/fstab.

When the system is rebooted,the system cannot find the device and fails to mount (for obvious reasons) the group. At that point the system prompts to enter the root password to go into recovery mode. Problem is, root is mounted read only so fstab can't be edited. Have to boot from the install media and go into recovery mode to edit fstab and remove the entry in fstab.

Then the reboot will work, but it takes a while to come up since when the system goes into recovery mode, selinux is put into permissive mode and the reboot requires a relabel. Ah, the adventures of Linux.

Version-Release number of selected component (if applicable):
system-config-lvm-1.1.15-1.fc14.noarch

How reproducible:
Only did this once. Too painful to try again. Besides, the bad drive is already packed and ready to go back for replacement.

 
Actual results:
mount information for logical group left in fstab after complete removal of group in system-config-lvm.

Expected results:
system-config-lvm should clean up the entry in fstab if the group is completely removed.
Comment 1 Marek Grac 2011-07-08 12:35:55 UTC 
@John:

thanks for reporting this problem. Surely something what I would like to fix.

By "logical group" you meant "volume group", am I right?

work-around: as a root you can do "mount -o remount,rw /" and then you can edit /etc/fstab without need for installation media.
Comment 2 John Griffiths 2011-07-08 14:33:59 UTC 
Actually I meant a logical volume like:

/dev/mapper/vg_host-lv_someVolume /someMountPoint    ext4    defaults        1 2
Comment 3 Marek Grac 2011-07-18 12:26:44 UTC 
Created attachment 513606 [details]
Proposed patch

@John:

ok, I have tested it and in new distros there is different way how to do a symlinks for logical volumes. I have added heuristic that guess /dev/mapper/... and it should be pretty solid. 

Patch will be in upstream in few days (and new version for fedora too).
Comment 4 Marek Grac 2011-07-21 10:01:45 UTC 
Patch is in upstream now:

http://git.fedorahosted.org/git/?p=system-config-lvm.git;a=commit;h=d97f18f6c012cfd428e9029f0a44b7c181f40d02
Comment 5 Fedora Update System 2011-07-22 10:18:55 UTC 
system-config-lvm-1.1.16-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/system-config-lvm-1.1.16-1.fc14
Comment 6 Fedora Update System 2011-07-23 02:05:50 UTC 
Package system-config-lvm-1.1.16-1.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-lvm-1.1.16-1.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/system-config-lvm-1.1.16-1.fc14
then log in and leave karma (feedback).
Comment 7 John Griffiths 2011-07-23 16:16:12 UTC 
All my systems are FC15 now, so cannot do anything for FC14. Is this being rolled forward?
Comment 8 Marek Grac 2011-07-24 15:20:27 UTC 
yes, F14, F15 and rawhide - pushing to stable today
Comment 9 Fedora Update System 2011-08-09 01:26:40 UTC 
system-config-lvm-1.1.16-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.