Bug 658907
| Summary: | Update ifcfg-rh plugin's handling of IPv4 manual addresses to match initscripts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jirka Klimes <jklimes> | ||||||||
| Component: | NetworkManager | Assignee: | Dan Williams <dcbw> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | 14 | CC: | dcbw, rkhan | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | NetworkManager-0.8.4-1.fc14 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-04-23 03:58:28 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Jirka Klimes
2010-12-01 15:40:14 UTC
Created attachment 464031 [details]
update manual IPv4 addresses handling
Can you update the testcases too with a sample ifcfg file using the new syntax? Then it should be fine to commit... though one thing the code explicitly did before was convert NETMASK to PREFIX, since NETMASK is old notation. ie I don't think we should ever write NETMASK back out, just PREFIX. Created attachment 491497 [details]
update manual IPv4 addresses handling v2
Updates handling of IPADDR<n>, PREFIX<n> (NETMASK<n>) and GATEWAY<n> to be compatible with initscripts.
writer:
- writes the sequence as IPADDR0, IPADDR1, .. IPADDR255
- NETMASK variables are not written out, just removed
reader:
- is tolerant when reading the addresses:
- supports previous IPADDR, IPADDR2, IPADDR3, ...
- new IPADDR0, IPADDR1, ...
- and combinations there IPADDR, IPADDR0, IPADDR1 are optional and IPADDR<n>,
where n>=2 are contiguous.
E.g.: IPADDR0, IPADDR2, IPADDR3, ...
IPADDR, IPADDR1, IPADDR2, ...
IPADDR2, IPADDR3, IPADDR4, ...
Created attachment 491498 [details]
ifcfg-rh: testcases for the changes
Fixed upstream: 0.8.x: 12d2ed3d4521c00b68237a338747ed243a63de77 (main fix) a9662641060eb95964ab15c5fbcf8c86eae48fa4 (testcases) c10fbb21be6c4a3cdf38b6d97b0cc58cb39807c2 (testcases) master: ccd39a8cb950a9e154d2e1a5816af84c78819de1 (main fix) b7b5599fb31935d76c48d802d58e66bd630f4d37 (testcases) NetworkManager-0.8.3.999-2.git20110414.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/NetworkManager-0.8.3.999-2.git20110414.fc14 NetworkManager-0.8.3.999-2.git20110414.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/NetworkManager-0.8.3.999-2.git20110414.fc13 Package NetworkManager-0.8.3.999-2.git20110414.fc13: * should fix your issue, * was pushed to the Fedora 13 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing NetworkManager-0.8.3.999-2.git20110414.fc13' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/NetworkManager-0.8.3.999-2.git20110414.fc13 then log in and leave karma (feedback). NetworkManager-0.8.998-3.git20110419.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/NetworkManager-0.8.998-3.git20110419.fc15 NetworkManager-0.8.4-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/NetworkManager-0.8.4-1.fc14 NetworkManager-0.8.4-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/NetworkManager-0.8.4-1.fc13 NetworkManager-0.8.998-3.git20110419.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. NetworkManager-0.8.4-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. NetworkManager-0.8.4-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |