Bug 659152
Summary: | JON241: traits that have non-null values show values of "?" in the CLI | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Charles Crouch <ccrouch> |
Component: | CLI | Assignee: | Lukas Krejci <lkrejci> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Corey Welton <cwelton> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 3.0.0 | CC: | hbrock, ian.springer, jsanda, jshaughn, kbaker, skondkar, tao |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 614251 | Environment: | |
Last Closed: | 2011-05-24 01:11:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 614251 | ||
Bug Blocks: | 616081 |
Description
Charles Crouch
2010-12-02 01:24:30 UTC
Lukas please move the fix over from master into the release30 branch. commit a48b635436d08a1412a4b6894635309e281c979c Author: John Sanda <jsanda> Date: Tue Oct 12 11:11:48 2010 -0400 [BZ 614251] Forgot to include updated interface in previous commit commit 813b652727f525a2f03748d15a6edaec1db6a097 Author: John Sanda <jsanda> Date: Tue Oct 12 10:55:23 2010 -0400 [BZ 614251] Making multiple changes so that live metric data can be fetched and displayed There are two changes with this commit. First, in the CLI the ResourceProxy class was using a criteria query that is too broad, at least when the jboss-as and jboss-as-5 plugins are involved. Secondly, the server/agent API used to get the metric data is inadequate. It accepts a variable number of measurement names but only a single data type for those measurements. This is problematic because there is nothing to guarantee that all of the metrics are of the same type. On the server side, we were using a hard-coded value of METRIC for the data type argument. The method(s) MeasurementManagerLocal.findLiveData and MeasurementManagerRemote.findLiveData will fail any time one of the measurement definitions has a data type other than METRIC. MeasurementManager.getRealTimeMeasurementValue has been refactored to take a list of MeasurementDataRequest objects. Each request specifies the metric name along with its corresponding data type. Verified on Jon241 build#35 Inventoried an JBoss EAP running the 'production' configuration. Installed the Command Line Client. Started the CLI and connected to the RHQ Server. Retrieved the same JBoss EAP server Resource. After running the 'jvmProxy' on cli, observed that the traits does not display ? for non-null values as below: rhqadmin.193.104:7080$ jvmProxy ResourceClientProxy_$$_javassist_0: JVMFreeMemory: 219.9MB JVMMaxMemory: 499.2MB JVMTotalMemory: 499.2MB activeThreadCount: 118.0 activeThreadGroupCount: 8.0 buildDate: 20100618 children: clusterPartitionName: DefaultPartition contentTypes: {library=JAR Library, cumulativePatch=Cumulative Patch} createdDate: Mon Dec 06 12:17:30 IST 2010 description: JBoss Enterprise Application Platform handler: id: 11851 measurements: [Start Date, Cluster Partition Name, JVM Free Memory, Transactions Committed per Minute, Total Transactions, Server Home Dir, Transactions Committed, Active Thread Group Count, Version Name, Server Name, Total Transactions per Minute, Active Thread Count, Transactions Rolled Back per Minute, JVM Total Memory, JVM Max Memory, Build Date, Transactions Rolled Back] modifiedDate: Mon Dec 06 12:17:30 IST 2010 name: localhost.localdomain:1099 production operations: [org.rhq.enterprise.client.proxy.ResourceClientProxy$Operation@53c3f5, org.rhq.enterprise.client.proxy.ResourceClientProxy$Operation@166340c, org.rhq.enterprise.client.proxy.ResourceClientProxy$Operation@e33e18] pluginConfiguration: pluginConfigurationDefinition: ConfigurationDefinition[id=10126, name=JBossAS Server] resourceType: JBossAS Server serverHomeDir: /NotBackedUp/jon3.1/eap5.1/jboss-5.1.0.Branch/server/production serverName: production startDate: Mon Dec 06 12:14:48 IST 2010 totalTransactions: 0.0 totalTransactionsperMinute: 0.0 transactionsCommitted: 0.0 transactionsCommittedperMinute: 0.0 transactionsRolledBack: 0.0 transactionsRolledBackperMinute: 0.0 version: 5.1.0.Branch versionName: EAP Bookkeeping - closing bug - fixed in recent release. Bookkeeping - closing bug - fixed in recent release. |