Bug 659703

Summary:	cancel_sync issues when running the repo sync is running with -F option
Product:	[Retired] Pulp	Reporter:	Preethi Thomas <pthomas>
Component:	z_other	Assignee:	John Matthews <jmatthew>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	jmatthew, tsanders
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-08-16 14:00:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	647488

Description Preethi Thomas 2010-12-03 14:35:04 UTC

Description of problem:


Steps to reproduce
1.On one window, run repo sync -F
2. Open another command line window and cancel the above sync by running cancel_sync
3. you get the Sync for repository canceled message.
4. On the first window see that the sync progress is stalled indicating the canceled sync 
5. Now run the repo status for the above repo on the second window
6. See that the repo status is  hanging
7. Ctrl+C on the first window to exit from the stalled sync
9. Run repo status on the above repo again
10. See that its hanging

Additional info:

Comment 1 John Matthews 2011-01-04 20:19:48 UTC

Please re-test, I think this is fixed now.

sync -F was cancelled and returned as soon as I issued the cancel.
repo status returned promptly and did not hang.

$ sudo pulp-admin -u admin -p admin repo sync --id cancel_test -F
Sync for repository cancel_test started
You can safely CTRL+C this current command and it will continue
[                                                     ] 0%
Sync: Canceled


$ sudo pulp-admin -u admin -p admin repo status --id cancel_test
+------------------------------------------+
           Status for cancel_test
+------------------------------------------+
Repository: cancel_test
Number of Packages: 0
Last Sync: never

Comment 2 Preethi Thomas 2011-01-04 21:32:58 UTC

This still happens. I did not see the repo status hanging.But cancel_sync never relays to the first window.

[root@10 ~]# pulp-admin repo cancel_sync --id=f13
Sync for repository f13 canceled



[root@10 ~]# pulp-admin repo sync --id=f13 -F
Sync for repository f13 already in progress
You can safely CTRL+C this current command and it will continue
[                                                     ] 0%

Comment 3 John Matthews 2011-01-04 22:20:26 UTC

I'm moving this to MODIFIED so we can re-test with the next build.
Might be this was recently fixed and not in the available QE build.

When testing with latest git master the sync -F is interrupted and exists immediately after issuing a "cancel_sync" from another window.

Comment 4 Jay Dobies 2011-01-05 19:45:29 UTC

Fixed in 0.120.

Comment 5 Preethi Thomas 2011-01-06 14:16:57 UTC

Looks like this is working

[root@preethi ~]# rpm -q pulp
pulp-0.0.120-1.fc14.noarch

[root@preethi ~]# pulp-admin repo cancel_sync --id=f13 
Sync for repository f13 canceled

[root@preethi ~]# pulp-admin repo sync --id=f13 -F 
Sync for repository f13 started
You can safely CTRL+C this current command and it will continue
[=============                                     ] 26% (940 of 3111 pkgs)
Sync: Canceled

[root@preethi ~]# pulp-admin repo status --id=f13
+------------------------------------------+
               Status for f13
+------------------------------------------+
Repository: f13
Number of Packages: 0
Last Sync: never

Comment 6 Preethi Thomas 2011-08-16 14:00:22 UTC

Closing with Community Release 15

pulp-0.0.223-4.