Bug 659746
| Summary: | Review Request: dee - Model to synchronize multiple instances over DBus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | Package Review | Assignee: | Jef Spaleta <jspaleta> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jspaleta, notting, tcallawa |
| Target Milestone: | --- | Flags: | jspaleta:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-14 17:47:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Williamson
2010-12-03 15:32:38 UTC
one improvement here would be to use the in-built test suite, but I'd have to package dbus-test-runner too, for that. may do that if I get time later. Just FYI, I don't think I can pass this through review until there is at least a comment from upstream concerning the missing license headers. At least a clarification of intention in the upstream report would be enough for me as a archived statement on record. That being said...... I think you have to leave the GPLv3 in the license field because the srpm does ship with the example and test code. It's not just the binary..we do distribute the srpm's as well and the licensing tag has to make sense for both the srpm and the binary rpm. -jef "Just FYI, I don't think I can pass this through review until there is at least a comment from upstream concerning the missing license headers." I think we're generally okay to ship source which has no specific header but is clearly marked with an acceptable license in other ways by upstream (dee is on the project page, and by the inclusion of the license files in the tarball); having a header on each specific source file is a 'nice-to-have', not a must. But I'll CC spot to check this. "It's not just the binary..we do distribute the srpm's as well and the licensing tag has to make sense for both the srpm and the binary rpm." No, it doesn't. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines "The License: field refers to the licenses of the contents of the *binary* rpm. When in doubt, ask." Indeed. i missed that. Yippie for expansive guidance! spec file looks good. I just need finish the local mock build and confirm binary build stuff on a primary arch. -jef This is lovely. When trying to build dee against F14 I get an error concerning DBus-1.0.gir not available. On rawhide this is available in gobject-introspection-devel On F13 this is availabe in gir-repository-devel On F14 it appears to be unavailable from any package. Not a review blocker. Just be aware that once dee goes in it is going to be F15+ only. -jef that's fine, I wasn't really planning on targeting F14. Looks good. Builds without error on 64bit rawhide under mock. Binary packages appear well formed with correct ownership for files and directories. No executables or associated desktop files to worry about. ldconfig called in scriptlets for install libraries. Minimal docs in the main package with COPYING file -devel subpackage looks good. rpmlint runs have ignorable warnings. Passes review for rawhide and fc15+ New Package SCM Request ======================= Package Name: dee Short Description: Model to synchronize multiple instances over DBus Owners: adamwill Branches: InitialCC: whoops, set the fedora-cvs flag to + instead of ?...doh. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Git done (by process-git-requests). okay, thanks, closing. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers |