Bug 660324

Granting pm_ack+. We need this package to support the comprehensive SNMP TRAP capabilities that we're building out in RHEL 6.1 for the RHEL HA Add-On. There is a lot of customer demand for this feature and cannot be postponed to RHEL 6.2.

*** Bug 629383 has been marked as a duplicate of this bug. ***

*** Bug 561413 has been marked as a duplicate of this bug. ***

SRPM and spec file:

http://people.redhat.com/~rohara/foghorn/foghorn-0.1-1.fc13.src.rpm
http://people.redhat.com/~rohara/foghorn/foghorn.spec

Review was performed on foghorn.spec 0.1.1-2


MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

  * PASS:
    $ rpmlint foghorn.spec
    0 packages and 1 specfiles checked; 0 errors, 0 warnings.

MUST: The package must be named according to the Package Naming Guidelines

  * PASS: foghorn-0.1.1-1 matches package name and tarball

MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.

  * PASS

MUST: The package must meet the Packaging Guidelines.

  * PASS

MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.

  * PASS: GPL v2 or later

MUST: The License field in the package spec file must match the actual license.

  * PASS

MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.

  * PASS; COPYING is %doc'd

MUST: The spec file must be written in American English.

  * PASS

MUST: The spec file for the package MUST be legible.
  * PASS

MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.

  * PASS
    f8ec246d07c30e7071b35730ad7c6157  foghorn-0.1.1.tar.gz

MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.

  * PASS; Built on all architectures

MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.

  * PASS; see previous note.

MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.

  * PASS; successfully built in build system

MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

  * N/A; package does not use locales.

MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.

  * N/A; package does not provide libraries

MUST: Packages must NOT bundle copies of system libraries.

  * PASS; no libraries
MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.

  * N/A; not relocatable

MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.

  * PASS:
    * Directory: /etc/rc.d/init.d
      Provided by: initscripts
      Package requires: initscripts
    * Directory: /usr/share/snmp/mibs
      Provided by: net-snmp-libs
      Package requires: net-snmp, which requires net-snmp-libs
    * Directory: /etc/dbus-1/system.d
      Provided by: dbus
      Package requires: dbus

MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)

  * PASS

MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line.

  * PASS

MUST: Each package must consistently use macros.

  * PASS

MUST: The package must contain code, or permissable content.

  * PASS, package contains code

MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).

  * N/A; no doc files apart from COPYING/ChangeLog/etc

MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.

  * PASS

MUST: Header files must be in a -devel package.

  * N/A - no header files

MUST: Static libraries must be in a -static package.

  * N/A - no libraries

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.

  * N/A - no libraries

MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}

  * N/A - no devel package

MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.

  * PASS

MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.

  * N/A - no GUI

MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.

  * PASS

MUST: All filenames in rpm packages must be valid UTF-8.

  * PASS

SHOULD Items:

SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.

  * PASS: COPYING is included and is text of GPLv2

SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.

  * No translations available

SHOULD: The reviewer should test that the package builds in mock.

  * PASS: built on all architectures in build system

SHOULD: The package should compile and build into binary rpms on all supported architectures.

  * PASS: built on all architectures in build system (implying mock)

SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.

  * Did not test.

SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.

  * N/A: No scriptlets

SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.

  * N/A: No subpackages

SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.

  * N/A; no development libraries or pkgconfig files

SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.

  * PASS: all dependencies are correct

SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.

  * Oops: Missing man page for foghorn

just a note here, foghorn is currently not supported in latest selinux policy (ends up in initrc_t).

Created https://bugzilla.redhat.com/show_bug.cgi?id=693792 for selinux policy tracking.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0635.html