Bug 661143 (votca-tools)
| Summary: | Review Request: votca-tools - VOTCA tools library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, junghans, notting |
| Target Milestone: | --- | Flags: | dominik:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | votca-csg-1.0.1-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-25 00:27:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 661154 | ||
|
Description
Susi Lehtola
2010-12-07 21:43:09 UTC
*** Bug 660061 has been marked as a duplicate of this bug. *** Notes from my side: - "coarse-graining" is spell correctly. - I have removed the exit call in libtools, this will be fixed in the next release - there is doxygen documentation through 'make html' Taking the review. Source matches upstream: $ md5sum votca-tools-1.0.1.tar.gz* 8401cc8f762543a89cb015ef153ca172 votca-tools-1.0.1.tar.gz 8401cc8f762543a89cb015ef153ca172 votca-tools-1.0.1.tar.gz.1 Notes: 1. If you intend to build for EPEL5, you need to add Requires: pkgconfig to the -devel subpackage. 2. "install -p" should be used instead of plain install to preserve timestamps, please override that with INSTALL="install -p" Otherwise the package is fine. Please fix number 2 and it will be approved. (In reply to comment #2) > - there is doxygen documentation through 'make html' Doesn't work: $ make html ... Making html in doc make[2]: Entering directory `/home/rathann/build/BUILD/votca-tools-1.0.1/share/doc' make[2]: *** No rule to make target `Doxyfile', needed by `html'. Stop. Did both. http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-tools.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-tools-1.0.1-2.fc14.src.rpm (In reply to comment #4) > 2. "install -p" should be used instead of plain install to preserve timestamps, > please override that with INSTALL="install -p" Is this a problem in our build system or in autotools? > (In reply to comment #2) > > - there is doxygen documentation through 'make html' > Doesn't work: > make[2]: *** No rule to make target `Doxyfile', needed by `html'. Stop. I forgot to add 'Doxyfile' to EXTA_DIST (fixed in the next release). In case you still want it, it can be found here: http://tools.votca.googlecode.com/hg/share/doc/Doxyfile But I think it is not necessary due to the fact that one can browse the documentation at http://doc.votca.org Excellent. This package is APPROVED. (In reply to comment #6) > (In reply to comment #4) > > 2. "install -p" should be used instead of plain install to preserve timestamps, > > please override that with INSTALL="install -p" > Is this a problem in our build system or in autotools? autotools don't use -p by default. > I forgot to add 'Doxyfile' to EXTA_DIST (fixed in the next release). > In case you still want it, it can be found here: > http://tools.votca.googlecode.com/hg/share/doc/Doxyfile > But I think it is not necessary due to the fact that one can browse the > documentation at http://doc.votca.org Indeed. Thanks a lot for the review! New Package SCM Request ======================= Package Name: votca-tools Short Description: VOTCA tools library Owners: jussilehtola Branches: F-13 F-14 InitialCC: Git done (by process-git-requests). votca-tools-1.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/votca-tools-1.0.1-2.fc14 votca-tools-1.0.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/votca-tools-1.0.1-2.fc13 votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13 votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update votca-csg votca-tools'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. votca-csg-1.0.1-2.fc13, votca-tools-1.0.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |