Bug 661594

Summary:	format of the server ip is not checked during the syslog configuration
Product:	Red Hat Enterprise Linux 6	Reporter:	fyu
Component:	ovirt-node	Assignee:	Joey Boggs <jboggs>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.0	CC:	apevec, cshao, gouyang, jboggs, kli, mburns, moli, mshao, ovirt-maint, zdover
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-node-2.0.2-0.7.gitb88a4ee.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 19:06:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description fyu 2010-12-09 05:40:01 UTC

Description of problem:
There's no check for the format of ip when trying to enter a syslog server ip.

Version-Release number of selected component (if applicable):
rhevh 6.0-15

How reproducible:
Always

Steps to Reproduce:
1. Setup the networking and storage respectively.
2. Choose "6) Logging setup".
3. When asked for the max size of local log files, input a suitable value.
4. Then the question"What is the IP address for the syslog server, hit Enter to skip?" appears, input 999 and press enter.
  
Actual results:
The wrong ip "999" is accepted and will be saved in the configuration. 

Expected results:
The format of ip address should be checked to avoid typo mistakes.
If an attempt for verification will be performed before the syslog configuration is saved, it will be better.


Additional info:

Comment 7 Guohua Ouyang 2011-08-12 02:35:07 UTC

test below values report "invalid hostname or address" as expected now:
999
aaa
10.66.9.256
10.66.9.1.234

but it also blocked valid hostname:
rhevh.test.com   "invalid hostname or address"
rhevh.com        "invalid hostname or address"

BTW, test "rhevh.test.com" & "rhevh.com" in hostname under network, it's accepted.

Comment 12 kli 2011-09-08 07:20:54 UTC

server address           Actual results:                Expected results:
999                 （invalid hostname or address） （invalid hostname or address）
aaa             （approve without Error reporting) （invalid hostname or address）
10.66.9.256               approve                          approve
10.66.9.1.234    （approve without Error reporting) （invalid hostname or address）
10.66.2222222222 （approve without Error reporting) （invalid hostname or address）
rhevh.test.com           approve                           approve
rhevh.com                approve                           approve

test below values  should report "invalid hostname or address" as expecte,however there is no reporting :

aaa
10.66.9.1.234 
10.66.2222222222

Comment 14 Alan Pevec 2011-09-12 21:29:17 UTC

> server address           Actual results:                Expected results:
> 999                 （invalid hostname or address） （invalid hostname or address）

From my reading of relevant RFCs, numbers-only can be a valid hostname, see bug 720956 comment 12

Comment 16 Guohua Ouyang 2011-09-14 02:21:11 UTC

according comment #14, assign the bug back.

But in my opinion, syslog server is usually a remote server， use rhevh itself as the log server isn't the normal case.(drop to shell is not supported action.)
so we can keep it simple, only use valid ip and fqdn hostname here.

for my above comment, I think we can also keep consistence with rhevm, kdump location(nfs&ssh).

Comment 21 Zac Dover 2011-10-24 03:20:58 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Red Hat Enterprise Virtualization Hypervisor now checks the format of the server IP address that you input. If the IP address is in the wrong format, Red Hat Enterprise Virtualization Hypervisor presents you with an error message.

Comment 22 Alan Pevec 2011-10-25 12:34:18 UTC

Deleted Technical Notes Contents.

Old Contents:
Red Hat Enterprise Virtualization Hypervisor now checks the format of the server IP address that you input. If the IP address is in the wrong format, Red Hat Enterprise Virtualization Hypervisor presents you with an error message.

Comment 23 errata-xmlrpc 2011-12-06 19:06:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1783.html