Bug 661881

+++ This bug was initially created as a clone of Bug #592613 +++

Description of problem:
clufindhostname -i myhost.example.com returns random value.

Version-Release number of selected component (if applicable):
Tested with 2.0.56-6 (latest) 

How reproducible:
Every time.. 


Steps to Reproduce:
1. clufindhostname -i myhost.example.com 
2. most likely it will return a funny value and make nfsclient check in the cluster go south.

Problem is that:
inet_pton:
0 is returned if src does not contain  a  character  string  representing  a  valid  network address. A positive value is returned if the network address was successfully converted.

From  clufindhostname source code:

if (inet_pton(family, optarg, ptr) < 0) {
        perror("inet_pton");
        exit(2);
}

The check should be:

if (inet_pton(family, optarg, ptr) <= 0) {
        perror("inet_pton");
        exit(2);
}

Cheers D

--- Additional comment from lhh on 2010-12-09 16:06:20 EST ---

Patch pushed upstream:

http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=b057008da82f0caeb539e33575eb1f0a07da192c