Bug 662951

Summary:	Review Request: perl_checker - Verify Perl code
Product:	[Fedora] Fedora	Reporter:	Thierry Vignaud <thierry.vignaud>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED INSUFFICIENT_DATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, misc, notting, steve.traylen, xavier
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-26 15:51:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thierry Vignaud 2010-12-14 09:12:38 UTC

Spec URL: http://kenobi.mandriva.com/~tv/FC/perl_checker.spec
SRPM URL: http://kenobi.mandriva.com/~tv/FC/perl_checker-1.2.11-1.fc14.src.rpm
Description: This is a perl equivalent of clint which is widely used at Mandriva.

This is one of my first package for Fedora (I'm packaging for Mandriva Linux
since 1999), and I'm seeking a sponsor for Fedora.

Comment 1 Xavier Bachelot 2010-12-14 15:37:34 UTC

I'm not a sponsor but from a quick glance, here are a couple comments that will hopefully help.
- Don't define version and release twice. Just use plain "Version: 1.2.3", for example.
- Source0 must be a full URL.
- BuildRequires/Obsolotes/Provides for perl-MDK-Common looks dubious and are probably uneeded for the Fedora package.
- Why disable AutoReqProv ?
- %defattr should be %defattr(-,root,root,-)
- Watch out for potentially unowned files/dirs or missing Requires (%{_datadir}/vim/ftplugin ; %{_sysconfdir}/emacs/site-start.d)
- You might want to trim the changelog not too include the full Mandriva history. It is obviously fine to keep a comment about the source of this spec though.

Comment 2 Steve Traylen 2011-01-22 18:31:55 UTC

Hi Thierry, 

Are you able to provide new packages based on Xavier's comments. They are all valid.

Steve.

Comment 3 Michael S. 2011-11-26 15:51:01 UTC

The url is no longer valid ( afaik, the home was trashed on the server at mandriva ), so i am closing the bug report until a new spec is posted.