Bug 663018 (gnome-guitar)

Summary: Review Request: gnome-guitar - A small suite of applications for the guitarist
Product: [Fedora] Fedora Reporter: Narasimhan <lakshminaras2002>
Component: Package ReviewAssignee: Peter Lemenkov <lemenkov>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, lemenkov, notting
Target Milestone: ---Flags: lemenkov: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-24 10:29:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 489130    
Bug Blocks:    

Description Narasimhan 2010-12-14 13:11:27 UTC
SPEC file link : http://sites.google.com/site/lakshminaras2002/home/gnome-guitar.spec?attredirects=0&d=1

SRPM link : http://sites.google.com/site/lakshminaras2002/home/gnome-guitar-0.8.1-8.fc15.src.rpm?attredirects=0&d=1

rpmlint  -i gnome-guitar.spec  gnome-guitar-0.8.1-8.fc15.src.rpm gnome-guitar-0.8.1-8.fc15.x86_64.rpm gnome-guitar-devel-0.8.1-8.fc15.x86_64.rpm 
gnome-guitar.spec: W: invalid-url Source0: http://downloads.sourceforge.net/gnome-chord/gnome-guitar_cs-0.8.1.tar.gz <urlopen error timed out>
The value should be a valid, public HTTP, HTTPS, or FTP URL.

gnome-guitar.src: W: invalid-url Source0: http://downloads.sourceforge.net/gnome-chord/gnome-guitar_cs-0.8.1.tar.gz <urlopen error timed out>
The value should be a valid, public HTTP, HTTPS, or FTP URL.

gnome-guitar.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

gnome-guitar.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

gnome-guitar.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/libgnomeguitar.schemas
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

gnome-guitar.x86_64: W: no-manual-page-for-binary gnome-scale
Each executable in standard binary directories should have a man page.

gnome-guitar.x86_64: W: no-manual-page-for-binary gnome-chord
Each executable in standard binary directories should have a man page.

gnome-guitar-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
The value of this tag appears to be misspelled. Please double-check.

gnome-guitar-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

3 packages and 1 specfiles checked; 1 errors, 8 warnings.

The links that rpmlint complains about work when I copy paste them into the browser or when using wget.

Comment 1 Peter Lemenkov 2011-01-11 06:46:20 UTC
I'll review it

Comment 2 Peter Lemenkov 2011-01-11 09:27:01 UTC
Koji scratchbuild for F-15:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2714366

Comment 3 Peter Lemenkov 2011-01-11 10:41:54 UTC
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is not silent

work ~: rpmlint Desktop/gnome-guitar-*
gnome-guitar.x86_64: E: no-binary
gnome-guitar.x86_64: W: only-non-binary-in-usr-lib

^^^ This is a mono package - it does installs bytecode into arch-dependent locations.

gnome-guitar.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/libgnomeguitar.schemas

^^^ gconf data must not use  (noreplace) so it's ok too.

gnome-guitar.x86_64: W: no-manual-page-for-binary gnome-scale
gnome-guitar.x86_64: W: no-manual-page-for-binary gnome-chord

^^^ It's Ok too. Still no man-pages for these binaries.

gnome-guitar-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure

^^^ False positive. Should be ignored.

gnome-guitar-devel.x86_64: W: no-documentation

^^^ No documentation for this sub-package. So should be ignored too,

3 packages and 0 specfiles checked; 1 errors, 6 warnings.
work ~: 

+ The package is named according to the  Package Naming Guidelines. Citing from previous review: "upstream has slightly different name: gnome-guitar_cs, but according to the NamingGuidelines it is possible to change it e.g. if the original name uses wrong characters or would be somehow strange ;-) - ubuntu also already named the package without _cs"

+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines. 
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines (GPLv3+.
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum gnome-guitar_cs-0.8.1.tar.gz*
5b411154ff9a5445ddaec03bdc787a0067fc3e07c978dfc3560de2667f76f558  gnome-guitar_cs-0.8.1.tar.gz
5b411154ff9a5445ddaec03bdc787a0067fc3e07c978dfc3560de2667f76f558  gnome-guitar_cs-0.8.1.tar.gz.1
sulaco ~/rpmbuild/SOURCES: 

+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
+ The pkgconfig(.pc) files are stored in a -devel package and necessary runtime requirement added.
0 The package doesn't contain library files without a suffix (e.g. libfoo.so).
+ The -devel package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
>> + The package includes a %{name}.desktop file, and this file is properly installed with desktop-file-install in the %install section.

- The package MUST depend on hicolor-icon-theme due to dependency on /usr/share/icons/hicolor/64x64/apps directory. Perhaps some runtime dependency picks it up during installation process. Otherwise you MUST add explicit "Requires: hicolor-icon-theme".

Actually I believe that it's a generally good idea to list all such dependencies explicitly disregarding of whether underlying dependent packages pull them into installation chain. So I advice you to add "Requires: hicolor-icon-theme".

+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.


Ok, so here is a summary - please, comment the situation with hicolor-icon-theme (either prove that some underlying package from this package's dependency chain will install it, or explicitly add it as the Requires) and I'll finish the review.

Comment 4 Narasimhan 2011-01-11 16:52:12 UTC
Hello, 
Thanks for the review and comments.

I checked monodevelop spec file, it also adds hicolor-icon-theme explicitly in Requires. I have made the change in this spec file as well.

https://sites.google.com/site/lakshminaras2002/home/gnome-guitar.spec?attredirects=0&d=1

Comment 6 Peter Lemenkov 2011-01-11 17:48:30 UTC
Ok, I don't see any other issues, so this package is

APPROVED.

Comment 7 Narasimhan 2011-01-15 07:14:04 UTC
Thanks for the review.

Package Change Request
======================
Package Name: gnome-guitar
Owners: narasim

Requesting to unretire f14 and devel branches.

Comment 8 Jens Petersen 2011-01-18 07:10:39 UTC
Git done (by process-git-requests).

Comment 9 Jens Petersen 2011-01-18 07:14:52 UTC
Forgot to add you should use a "Branches: devel f14" for this request.

You can take f14 ownership at https://admin.fedoraproject.org/pkgdb/acls/name/gnome-guitar now.

Comment 10 Narasimhan 2011-01-18 07:17:27 UTC
Thanks,
Yes I have taken ownership

Comment 11 Narasimhan 2011-01-18 08:31:07 UTC
I had pasted the link of the rpm instead of the srpm in Comment 5.

Here is the srpm link https://sites.google.com/site/lakshminaras2002/home/gnome-guitar-0.8.1-9.fc15.src.rpm?attredirects=0&d=1

Comment 12 Narasimhan 2011-02-01 02:21:59 UTC
Waiting for releng to unblock the branches

https://fedorahosted.org/rel-eng/ticket/4362

Comment 13 Narasimhan 2011-02-12 05:56:58 UTC
Package Change Request
======================
Package Name: gnome-guitar
New Branches: f15
Owners: narasim

Comment 14 Narasimhan 2011-02-12 05:57:41 UTC
Rawhide build at 

http://koji.fedoraproject.org/koji/buildinfo?buildID=228288

Comment 15 Jason Tibbitts 2011-02-15 19:22:12 UTC
Git done (by process-git-requests).