Bug 663032
Summary: | wall command cuts the banner unfortunately | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Karel Volný <kvolny> | ||||
Component: | sysvinit | Assignee: | Petr Lautrbach <plautrba> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 14 | CC: | plautrba | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | sysvinit-2.87-7.dsf.fc14 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | |||||||
: | 668476 (view as bug list) | Environment: | |||||
Last Closed: | 2011-01-13 17:58:05 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 668476 | ||||||
Attachments: |
|
Description
Karel Volný
2010-12-14 14:24:33 UTC
There is limitation 80 chars in this broadcast message probably because of standard terminal size: src/dowall.c: 133 char line[81]; ... 165 if (remote) { 166 snprintf(line, sizeof(line), 167 "\007\r\nRemote broadcast message (%s):\r\n\r\n", 168 date); 169 } else { 170 snprintf(line, sizeof(line), 171 "\007\r\nBroadcast message from %s@%s %s(%s):\r\n\r\n", 172 user, hostname, tty, date); 173 } What should be reasonable size for you? 100? 255? without limit? hm, so the problem obviously is that the banner goes over the line limit if the hostname is too long (which it is, I've replaced my real hostname with "machine" here), then the newline characters get eaten by snprintf so ... - I think the limit should not include the non-spacing characters (like the bell and the newline characters) - personally, I'd lift the 80 characters limit (make it unlimited), as this is very unsafe assumption nowadays (konsole on my laptop has more that 150 characters, terminal on my FreeRunner phone has about 40 characters ... and the messages on my laptop are shown via KDE notifications which is graphical application ...) - if that is unacceptable, a) make sure that snprintf doesn't eat the newline characters b) try to shorten the banner or split it over multiple lines Created attachment 472250 [details]
raise limit for broadcast message
This patch raises limit for broadcast message to 400 (411) characters and changes creating message so white symbols won't be cut out.
(In reply to comment #3) > Created attachment 472250 [details] > raise limit for broadcast message > > This patch raises limit for broadcast message to 400 (411) characters and > changes creating message so white symbols won't be cut out. seems nice don't you have a package to test, pls? There is a rawhide build [1] and I will send it to updates-testing soon [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=213146 sysvinit-2.87-7.dsf.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/sysvinit-2.87-7.dsf.fc14 sysvinit-2.87-7.dsf.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sysvinit'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/sysvinit-2.87-7.dsf.fc14 sysvinit-2.87-7.dsf.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |