Bug 663203

Summary:	[RFE] mock SRPM validation
Product:	[Community] Publican	Reporter:	Jeff Fearn 🐞 <jfearn>
Component:	publican	Assignee:	Jeff Fearn 🐞 <jfearn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ruediger Landmann <rlandman+disabled>
Severity:	medium	Docs Contact:
Priority:	low
Version:	future	CC:	abeekhof, mmcallis, publican-list, rlandman
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	2.6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-26 00:42:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Fearn 🐞 2010-12-14 23:33:30 UTC

Description of problem:
Currently there is no validation of sources supplied in mock builds. Publican should detect mock and use rpmlint to validate the source RPM.

Version-Release number of selected component (if applicable):
2.5

Actual results:
Invalid SRPMs are use and generate invalid RPMs

Expected results:
Invalid SRPMS are detected and rejected.

Comment 1 Jeff Fearn 🐞 2010-12-15 02:24:24 UTC

Added call to rpmlint when mock is detected. Build will croak if rpmlint has errors.

Fixed in revision 1690

Comment 2 Jeff Fearn 🐞 2011-07-05 09:26:56 UTC

Back ported to branches/publican-2x

Committed revision 1800.

Comment 3 Ruediger Landmann 2011-07-25 04:04:30 UTC

Verified on Publican 2.6-0.t2

Comment 4 Andrew Beekhof 2011-08-15 11:53:37 UTC

What on earth for?

We use publican to build our in-tree docs, but its now barfing in fedora-15 because we have an unavoidable and completely unrelated rpmlint error.

This is in addition to being forced into having a versioned build dependancy on publican.

Comment 5 Andrew Beekhof 2011-08-16 01:43:28 UTC

Adding some clarifications after an IRC chat with Ryan:

The upstream project is Pacemaker and the command we're running from the Makefile is:
  $(PUBLICAN) build --publish --langs=all --formats=$(DOCBOOK_FORMATS)

The SRPM publican is checking in this case is the pacemaker one, since the docs are in the same SRPM as the code.  So when rpmlint complains about something in the code, it causes publican abort.

Ryan explained to me why the checks were necessary, but perhaps they could be limited to the "package" command.