Bug 663404

Summary:	Luci does not generate 100% well-formed code which showed up with Firefox forced to use strict parser (via application/xhtml+xml content type)
Product:	[Fedora] Fedora	Reporter:	Jan Pokorný [poki] <jpokorny>
Component:	luci	Assignee:	Ryan McCabe <rmccabe>
Status:	CLOSED CANTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	cfeist, fdinitto, rmccabe, rmusil
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-15 18:07:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Pokorný [poki] 2010-12-15 17:29:17 UTC

This should be summary bug for issues connected with not well-formed parts of what luci produces. Such issues were mostly tolerated before, but no longer if strict parsing is forced by using application/xhtml+xml content type (talking about Firefox but maybe this will be similar with other browsers) in connection with bug #663103.

In addition, corrected -- well-formed code means that it should be interpreted the same whichever browser is used (the same problem with xhtml output can be handled differently). Therefore this lays level above the discussion which content type is used, fixing existing issues can only help, not hurt.

Comment 1 Jan Pokorný [poki] 2010-12-15 17:36:59 UTC

1. unable to add existing cluster
=================================
Using application/xhtml+xml content type, it wasn't able to add existing
cluster in Firefox ("connect" button didn't work).

Commit http://git.fedorahosted.org/git/?p=luci.git;a=commit;h=8496abde58f595585eb54e8f633f6812756c79a3 addresses this issue.

Comment 2 Jan Pokorný [poki] 2010-12-16 13:15:17 UTC

A variable in global scope problem leaked with previously stated commit
(comment #1). Fix followed:
http://git.fedorahosted.org/git/?p=luci.git;a=commit;h=99e20225e34b9c6deb49bd7c048b27be40ffb491

Comment 3 Jan Pokorný [poki] 2010-12-22 15:14:29 UTC

Another step towards xhtml validity of luci has been done in http://git.fedorahosted.org/git/?p=luci.git;a=commit;h=9836fd615c408dad51f17ad020734cd3621a4c6d

- especially list of clusters wasn't displayed well
- some (still not all) validity problems reported by validator fixed
(- additionally, occurencies of tabs translated into spaces)

Comment 5 Jan Pokorný [poki] 2012-03-12 19:04:58 UTC

Fix will be in upcoming release.

Comment 6 Fedora End Of Life 2013-04-03 19:57:30 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 7 Jan Pokorný [poki] 2013-08-15 18:07:54 UTC

Luci is not maintained in Fedora anymore (for some time already).
Git contains the necessary fix, if needed.