Bug 663653

Some notes:

* BuildRoot tag
  - BuildRoot: line is no longer needed on Fedora:
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* Requires
  - rubygem(rack) is needed only for BuildRequires and not needed
    for Requires
  - Remove unneeded ">= 1" or ">= 1.0.0" parts on
    (Build)Requires: rubygem-foo. c.f.
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

* Cleaning
  - "rm -rf %{buildroot}" at the top of %install, %clean section
    are no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* Consistent path usage
  - Why do you add %_bindir/ before spec explicitly while you don't
    write /bin/rm or %_bindir/gem?

* Splitting out document files
  - Please consider to create -doc subpackage and move the following
    files / directories into -doc
---------------------------------------------------
%{geminstdir}/spec
%{geminstdir}/warden.gemspec
%{geminstdir}/Rakefile
%{gemdir}/doc/%{gemname}-%{version}
---------------------------------------------------

Thank you for your review. I have uploaded new versions here:

Spec URL: http://people.redhat.com/vondruch/rubygem-warden.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-warden-1.0.3-2.fc14.src.rpm

However, I did not removed the "Requires: rubygem(rack)" as you suggested. My reasons are:
1) Warden is Rack middle-ware, therefore it should depend on rack during runtime. Usage of warden without rack doesn't make too much sense.
2) Although there is not explicit "require 'rack'" in lib folder, there are references on "Rack" module. Developing some web application, there is high chance that some body did that require before warden had a chance (this might be considered as really minor bug of warden?).

And one additional point is that rack is explicitly specified as runtime dependency by the warden gem (see the warden.gemspec file https://github.com/hassox/warden/blob/v1.0.2/warden.gemspec#L92)

(In reply to comment #2)
> However, I did not removed the "Requires: rubygem(rack)" as you suggested. My

Sorry, I meant "Requires: rubygem(rspec)" is not needed.

Ah, Ok. Please find the updated files bellow:

Spec URL: http://people.redhat.com/vondruch/rubygem-warden.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-warden-1.0.3-3.fc14.src.rpm

Okay

(I don't think explicit %doc in -doc subpackage is needed,
 however not a blocker)

-----------------------------------------------------------
    This package (rubygem-warden) is APPROVED by mtasaka
-----------------------------------------------------------

Thank you for the review.

New Package SCM Request
=======================
Package Name: rubygem-warden
Short Description: Rack middle-ware that provides authentication
Owners: vondruch
Branches: f13 f14
InitialCC:

Git done (by process-git-requests).

rubygem-warden-1.0.3-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-warden-1.0.3-3.fc13

rubygem-warden-1.0.3-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-warden-1.0.3-3.fc14

Closing.

rubygem-warden-1.0.3-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-warden-1.0.3-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.