Bug 663926

Summary:	Review Request: lsyncd - Synchronize local directories with a remote targets
Product:	[Fedora] Fedora	Reporter:	Peter Robinson <pbrobinson>
Component:	Package Review	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	bloch, fedora-package-review, hdegoede, notting, ruben
Target Milestone:	---	Flags:	hdegoede: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-04 14:23:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Robinson 2010-12-17 11:42:46 UTC

SPEC: http://pbrobinson.fedorapeople.org/lsyncd.spec
SRPM: http://pbrobinson.fedorapeople.org/lsyncd-2.0.0-1.fc14.src.rpm

Description:
Lsyncd watches a local directory trees event monitor interface (inotify). 
It aggregates and combines events for a few seconds and then spawns one 
(or more) process(es) to synchronize the changes. By default this is rsync. 
Lsyncd is thus a light-weight live mirror solution that is comparatively 
easy to install not requiring new filesystems or blockdevices and does 
not hamper local filesystem performance.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2672754

Comment 1 Ruben Kerkhof 2010-12-17 16:26:53 UTC

Hi Peter,

This looks good to me, but what's missing IMHO is an example config file and an initscript.

Comment 2 Peter Robinson 2010-12-17 16:45:30 UTC

> This looks good to me, but what's missing IMHO is an example config file and an
> initscript.

OK, no examples included upstream so I'll have a look at our current custom compiled solution and see what I can come up with.

Comment 3 Hans de Goede 2011-02-10 10:22:45 UTC

I'll review this one.

Comment 4 Hans de Goede 2011-02-10 10:40:13 UTC

Full review done:

Good:
-----
- rpmlint checks return:
lsyncd.src: W: spelling-error %description -l en_US inotify -> notify, i notify, inotropic
lsyncd.src: W: spelling-error %description -l en_US rsync -> sync, r sync, Syncom
lsyncd.src: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems
lsyncd.src: W: spelling-error %description -l en_US blockdevices -> block devices, block-devices, blockades
lsyncd.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic
<blergh, ignore>
lsyncd.src:10: W: macro-in-comment %{name}
lsyncd.src:10: W: macro-in-comment %{version}
<idem>
lsyncd.src: W: no-cleaning-of-buildroot %clean
lsyncd.src: W: no-buildroot-tag
lsyncd.src: W: no-%clean-section
<this is ok for newer Fedora versions>
lsyncd.src: W: invalid-url Source0: lsyncd-2.0.0.tar.gz
<explained with comment in spec>
lsyncd.x86_64: W: spelling-error %description -l en_US inotify -> notify, i notify, inotropic
lsyncd.x86_64: W: spelling-error %description -l en_US rsync -> sync, r sync, Syncom
lsyncd.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems
lsyncd.x86_64: W: spelling-error %description -l en_US blockdevices -> block devices, block-devices, blockades
lsyncd.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic
<blergh, ignore>
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Needs work:
-----------
- rpmlint checks return:
lsyncd.x86_64: W: executable-stack /usr/bin/lsyncd
Nasty, not good, no idea why it is doing this. May have something to do
with lua?
- spec says license is GPLv2, but the copyright headers contain
 "or any later version", should be GPLv2+
- googlecode now seems to have sane download urls, for example:
  http://lsyncd.googlecode.com/files/lsyncd-2.0.0.tar.gz
- upstream has a new 2.0.2 release available

Comment 5 Peter Robinson 2011-05-04 14:23:54 UTC

It seems a dupe that was filed after this was done

*** This bug has been marked as a duplicate of bug 700757 ***