This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours

Bug 663983

Summary: Review Request: rubygem-boxgrinder-build-ec2-platform-plugin - BoxGrinder plugin to convert appliances to EC2 format
Product: [Fedora] Fedora Reporter: Marek Goldmann <mgoldman>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mtasaka, notting
Target Milestone: ---Flags: mtasaka: fedora‑review+
tibbs: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-boxgrinder-core-0.1.5-1.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-22 14:59:36 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 664111, 664113    

Description Marek Goldmann 2010-12-17 11:02:59 EST
Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-ec2-platform-plugin.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc15.src.rpm
Description:

BoxGrinder Build Elastic Compute Cloud (EC2) Platform Plugin to convert appliances to EC2 format
Comment 1 Mamoru TASAKA 2010-12-17 13:56:44 EST
Doesn't build due to missing BR:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2673785

By the way I would appreciate it if you would review my
review request (bug 639638)
Comment 2 Marek Goldmann 2010-12-18 04:57:06 EST
You're fast :) It now builds in Rawhide, see http://koji.fedoraproject.org/koji/taskinfo?taskID=2674464

Ah sorry, I forgot to review your request will do this over the weekend!
Comment 3 Mamoru TASAKA 2010-12-18 13:47:43 EST
Well, it seems that "boxgrinder-build-ec2-platform-plugin" cannot
be loaded:

# irb
irb(main):001:0> require "rubygems"
=> true
irb(main):002:0> require "boxgrinder-build-ec2-platform-plugin"
NoMethodError: undefined method `plugin' for main:Object
        from /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-ec2-platform-plugin-0.0.7/lib/boxgrinder-build-ec2-platform-plugin.rb:21
        from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
        from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
        from (irb):2
irb(main):003:0> quit

Would you tell me if this is expected?
Comment 4 Marek Goldmann 2010-12-18 15:33:18 EST
I would say partially. boxgrinder-build-ec2-platform-plugin.rb file should contain:

require 'boxgrinder-build/managers/plugin-manager'

On the other hand this plugin will be not used directly, like you tested it. Instead it'll be initialized by this plugin manager so it'll not break. I added it now to upstream git repo. It'll be pushed with next version - 0.0.8. IMHO it's not a blocker for this package, WDYT?

P.S. You'll see same behavior for there submitted review requests (s3 plugin - bug 664111, ebs plugin - bug 664113). Both also fixed in upstream git repo.

Thanks!
Comment 5 Mamoru TASAKA 2010-12-18 17:15:17 EST
Okay.

---------------------------------------------------------------------
    This package (rubygem-boxgrinder-build-ec2-platform-plugin)
    is APPROVED by mtasaka
---------------------------------------------------------------------
Comment 6 Marek Goldmann 2010-12-19 03:23:09 EST
Thank you!

New Package SCM Request
=======================
Package Name:      rubygem-boxgrinder-build-ec2-platform-plugin
Short Description: BoxGrinder plugin to convert appliances to EC2 format
Owners:            goldmann
Branches:          f13 f14
Comment 7 Kevin Fenzi 2010-12-21 01:25:15 EST
Git done (by process-git-requests).
Comment 8 Fedora Update System 2010-12-21 12:13:43 EST
rubygem-boxgrinder-core-0.1.5-1.fc14,rubygem-boxgrinder-build-0.7.0-1.fc14,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc14,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.5-1.fc14,rubygem-boxgrinder-build-0.7.0-1.fc14,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc14,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc14
Comment 9 Fedora Update System 2010-12-21 12:13:52 EST
rubygem-boxgrinder-core-0.1.5-1.fc13,rubygem-boxgrinder-build-0.7.0-1.fc13,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.5-1.fc13,rubygem-boxgrinder-build-0.7.0-1.fc13,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13
Comment 10 Fedora Update System 2010-12-21 19:04:46 EST
rubygem-boxgrinder-core-0.1.5-1.fc13, rubygem-boxgrinder-build-0.7.0-1.fc13, rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13, rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-core rubygem-boxgrinder-build rubygem-boxgrinder-build-rpm-based-os-plugin rubygem-boxgrinder-build-local-delivery-plugin rubygem-boxgrinder-build-vmware-platform-plugin rubygem-boxgrinder-build-ec2-platform-plugin'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.5-1.fc13,rubygem-boxgrinder-build-0.7.0-1.fc13,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13
Comment 11 Mamoru TASAKA 2010-12-22 14:59:36 EST
Closing.
Comment 12 Fedora Update System 2010-12-29 16:51:02 EST
rubygem-boxgrinder-core-0.1.5-1.fc13, rubygem-boxgrinder-build-0.7.0-1.fc13, rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13, rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2010-12-29 16:53:08 EST
rubygem-boxgrinder-core-0.1.5-1.fc14, rubygem-boxgrinder-build-0.7.0-1.fc14, rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc14, rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc14, rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc14, rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 14 Marek Goldmann 2011-01-25 03:06:04 EST
Package Change Request
======================
Package Name: rubygem-boxgrinder-build-ec2-platform-plugin
New Branches: el5 el6
Owners: goldmann
Comment 15 Jason Tibbitts 2011-01-25 09:09:41 EST
Git done (by process-git-requests).