Bug 663983
| Summary: | Review Request: rubygem-boxgrinder-build-ec2-platform-plugin - BoxGrinder plugin to convert appliances to EC2 format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Goldmann <mgoldman> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-boxgrinder-core-0.1.5-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-22 19:59:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 664111, 664113 | ||
|
Description
Marek Goldmann
2010-12-17 16:02:59 UTC
Doesn't build due to missing BR: http://koji.fedoraproject.org/koji/taskinfo?taskID=2673785 By the way I would appreciate it if you would review my review request (bug 639638) You're fast :) It now builds in Rawhide, see http://koji.fedoraproject.org/koji/taskinfo?taskID=2674464 Ah sorry, I forgot to review your request will do this over the weekend! Well, it seems that "boxgrinder-build-ec2-platform-plugin" cannot
be loaded:
# irb
irb(main):001:0> require "rubygems"
=> true
irb(main):002:0> require "boxgrinder-build-ec2-platform-plugin"
NoMethodError: undefined method `plugin' for main:Object
from /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-ec2-platform-plugin-0.0.7/lib/boxgrinder-build-ec2-platform-plugin.rb:21
from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
from (irb):2
irb(main):003:0> quit
Would you tell me if this is expected?
I would say partially. boxgrinder-build-ec2-platform-plugin.rb file should contain: require 'boxgrinder-build/managers/plugin-manager' On the other hand this plugin will be not used directly, like you tested it. Instead it'll be initialized by this plugin manager so it'll not break. I added it now to upstream git repo. It'll be pushed with next version - 0.0.8. IMHO it's not a blocker for this package, WDYT? P.S. You'll see same behavior for there submitted review requests (s3 plugin - bug 664111, ebs plugin - bug 664113). Both also fixed in upstream git repo. Thanks! Okay.
---------------------------------------------------------------------
This package (rubygem-boxgrinder-build-ec2-platform-plugin)
is APPROVED by mtasaka
---------------------------------------------------------------------
Thank you! New Package SCM Request ======================= Package Name: rubygem-boxgrinder-build-ec2-platform-plugin Short Description: BoxGrinder plugin to convert appliances to EC2 format Owners: goldmann Branches: f13 f14 Git done (by process-git-requests). rubygem-boxgrinder-core-0.1.5-1.fc14,rubygem-boxgrinder-build-0.7.0-1.fc14,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc14,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.5-1.fc14,rubygem-boxgrinder-build-0.7.0-1.fc14,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc14,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc14,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc14 rubygem-boxgrinder-core-0.1.5-1.fc13,rubygem-boxgrinder-build-0.7.0-1.fc13,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.5-1.fc13,rubygem-boxgrinder-build-0.7.0-1.fc13,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 rubygem-boxgrinder-core-0.1.5-1.fc13, rubygem-boxgrinder-build-0.7.0-1.fc13, rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13, rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-core rubygem-boxgrinder-build rubygem-boxgrinder-build-rpm-based-os-plugin rubygem-boxgrinder-build-local-delivery-plugin rubygem-boxgrinder-build-vmware-platform-plugin rubygem-boxgrinder-build-ec2-platform-plugin'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.5-1.fc13,rubygem-boxgrinder-build-0.7.0-1.fc13,rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13,rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13,rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 Closing. rubygem-boxgrinder-core-0.1.5-1.fc13, rubygem-boxgrinder-build-0.7.0-1.fc13, rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc13, rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc13, rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-boxgrinder-core-0.1.5-1.fc14, rubygem-boxgrinder-build-0.7.0-1.fc14, rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.9-1.fc14, rubygem-boxgrinder-build-local-delivery-plugin-0.0.6-1.fc14, rubygem-boxgrinder-build-vmware-platform-plugin-0.0.6-1.fc14, rubygem-boxgrinder-build-ec2-platform-plugin-0.0.7-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-boxgrinder-build-ec2-platform-plugin New Branches: el5 el6 Owners: goldmann Git done (by process-git-requests). |