Bug 664054

rpmlint

[jomara@jomara-host SRPMS]$ rpmlint python-rhsm-0.94.8-1.fc14.src.rpm 
python-rhsm.src: W: invalid-url Source0: python-rhsm-0.94.8.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

This is because that tarball isn't hosted at fedorahosted.org. Please provide instructions on how to get the tarball with git or a direct link, so I can md5sum the provided and hosted sources.

MUST ITEMS: 

package name : check
spec name : check
standard packaging guidelines : check
python packaging guidelines : 
  macro definitions for RHEL5 & below? not a showstopper
  otherwise check
license : check
english spec : check
legible spec : check
upstream src md5sum check : [FAIL] - see above
build check : check
build requires : check
locales : check
binary rpm : check
system library bundle : check
directory ownership: check
macros : check
doc : check
la libtools : check
other package file ownership : check
utf-8 filenames : check

SHOULD items that are missing:
query upstream license file
extra language translations


Summary: Please provide a location to download the source, and I think you are good to go.

git clone git://git.fedorahosted.org/git/candlepin.git/
cd client/python-rhsm
tito build --tag python-rhsm-%{name}-%{version}-%{release} --tgz | grep "Wrote:" | awk '{print $2}' | xargs -n 1 md5sum

I will add this comment to the spec file.

added comment on how to generate the tarball to the spec file. I left out
the part on how to get the md5sum as that's only useful for a reviewer.

Here are the updated srpm and spec file.

Spec URL: http://jmrodri.fedorapeople.org/python-rhsm.spec
SRPM URL:
http://jmrodri.fedorapeople.org/python-rhsm-0.94.9-1.fc13.src.rpm

Looks good! One extremely pedantic comment: the tito build RPM command ( tito build --tag python-rhsm-%{name}-%{version}-%{release} --tgz) would end up building python-rhsm-python-rhsm-0.94.9-1.

What's important is that I was able to cleanly build a source archive from the upstream repo, and it's MD5sum matches what you provided in the SRPM. Setting +

(In reply to comment #4)
> Looks good! One extremely pedantic comment: the tito build RPM command ( tito
> build --tag python-rhsm-%{name}-%{version}-%{release} --tgz) would end up
> building python-rhsm-python-rhsm-0.94.9-1.
> 
> What's important is that I was able to cleanly build a source archive from the
> upstream repo, and it's MD5sum matches what you provided in the SRPM. Setting +

Oops my typo. Sorry.

New Package SCM Request
=======================
Package Name: python-rhsm
Short Description: Small Python library for communicating with a Red Hat Unified
Entitlement Platform.
Owners: dgoodwin jmrodri 
Branches: f14 el6
InitialCC:

Git done (by process-git-requests).

Package Change Request
======================
Package Name: python-rhsm
New Branches: el5 
Owners: dgoodwin, jmrodri
InitialCC: 

Pulp would like to see this in el5. It is currently in el6.

Git done (by process-git-requests).