Bug 664391

Summary:	Review Request: libechonest - C++ wrapper for the Echo Nest API
Product:	[Fedora] Fedora	Reporter:	Orcan Ogetbil <oget.fedora>
Component:	Package Review	Assignee:	Jaroslav Reznik <jreznik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, jreznik, notting
Target Milestone:	---	Flags:	jreznik: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	libechonest-1.1.0-1.fc13	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-01-07 19:57:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Orcan Ogetbil 2010-12-20 09:47:06 UTC

Spec URL: http://oget.fedorapeople.org/review/libechonest.spec
SRPM URL: http://oget.fedorapeople.org/review/libechonest-1.1.0-1.fc14.src.rpm
Description: 
libechonest is a collection of C++/Qt classes designed to make a developer's
life easy when trying to use the APIs provided by The Echo Nest.


This package is needed for the new version of clementine, and probably amarok at some point.

Comment 1 Jaroslav Reznik 2010-12-20 11:20:31 UTC

Name: ok
Version: ok
Release: ok
Summary: ok
Group: ok
License: ok, GPLv2+
URL: ok
Source: ok, md5sum 1e7730114952a3163fa2041cbfe523d8
BuildRequires: ok
Description: ok
Devel subpacakge: ok (.so and includes)
Macros consistent usage: ok
Ldconfig: ok
Docs: ok

rpmlint ../rpmbuild/SPECS/libechonest.spec 
../rpmbuild/SPECS/libechonest.spec:52: W: macro-in-comment %{_target_platform}
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

ok

rpmlint ../rpmbuild/RPMS/x86_64/libechonest-1.1.0-1.fc14.x86_64.rpm 
libechonest.x86_64: W: incoherent-version-in-changelog 1.1.0 ['1.1.0-1.fc14', '1.1.0-1']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

just a minor issue, please fix to 1.1.0-1 before commiting, not blocking review

APPROVED

Comment 2 Orcan Ogetbil 2010-12-20 18:37:01 UTC

Thank you for the quick review Jaroslav. I'll fix the %changelog

New Package SCM Request
=======================
Package Name: libechonest
Short Description: C++ wrapper for the Echo Nest API
Owners: oget
Branches: F-13 F-14
InitialCC:

Comment 3 Kevin Fenzi 2010-12-21 06:27:13 UTC

Git done (by process-git-requests).

Comment 4 Fedora Update System 2010-12-21 09:47:33 UTC

libechonest-1.1.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/libechonest-1.1.0-1.fc14

Comment 5 Fedora Update System 2010-12-21 09:48:03 UTC

libechonest-1.1.0-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/libechonest-1.1.0-1.fc13

Comment 6 Fedora Update System 2010-12-22 00:00:23 UTC

libechonest-1.1.0-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libechonest'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libechonest-1.1.0-1.fc14

Comment 7 Fedora Update System 2011-01-07 19:57:12 UTC

libechonest-1.1.0-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2011-01-07 20:00:28 UTC

libechonest-1.1.0-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.