Bug 665190
Summary: | Review Request: perl-List-UtilsBy - Higher-order list utility functions | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-List-UtilsBy-0.06-1.fc13 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-01-22 20:30:29 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 665189 |
Description
Ralf Corsepius
2010-12-23 02:57:44 UTC
- rpmlint: rpmlint perl-List-UtilsBy-0.06-1.fc15.src.rpm W: spelling-error %description -l en_US behaviour -> behavior, behave, behalves ^ that's not American English, but seems to me rude changing description from British author to something else. Therefore OK W: spelling-error %description -l en_US Util -> Til, U til, Utile ^ nonsense - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK ^ http://koji.fedoraproject.org/koji/taskinfo?taskID=2704543 - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK rpm -qp --provides ../RPMS/noarch/perl-List-UtilsBy-0.06-1.fc14.noarch.rpm perl-List-UtilsBy = 0.06-1.fc14 rpm -qp --requires ../RPMS/noarch/perl-List-UtilsBy-0.06-1.fc14.noarch.rpm perl(:MODULE_COMPAT_5.12.2) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 ACCEPT Thanks for the review. New Package CVS Request ======================= Package Name: perl-List-UtilsBy Short Description: Higher-order list utility functions Owners: corsepiu Branches: f13 f14 InitialCC: perl-sig I found there's missing one provides. Add: Provides: perl(List::UtilsBy) You can't build dependent package without it. # (In reply to comment #3) > I found there's missing one provides. Add: > Provides: perl(List::UtilsBy) > You can't build dependent package without it. Which target are you building for? # rpm -qlp perl-List-UtilsBy-0.06-1.fc14.noarch.rpm /usr/share/doc/perl-List-UtilsBy-0.06 /usr/share/doc/perl-List-UtilsBy-0.06/Changes /usr/share/doc/perl-List-UtilsBy-0.06/LICENSE /usr/share/doc/perl-List-UtilsBy-0.06/README /usr/share/man/man3/List::UtilsBy.3pm.gz /usr/share/perl5/List /usr/share/perl5/List/UtilsBy.pm # rpm -q --provides -p perl-List-UtilsBy-0.06-1.fc14.noarch.rpm perl(List::UtilsBy) = 0.06 perl-List-UtilsBy = 0.06-1.fc14 Same for a local f15 built: # rpm -q --provides -p /var/lib/mock/fedora-rawhide-i386/result/perl-List-UtilsBy-0.06-1.fc15.noarch.rpm perl(List::UtilsBy) = 0.06 perl-List-UtilsBy = 0.06-1.fc15 Could it be you simply didn't specify the arguments in your rpmquery call correctly? Note what you wrote in comment #1: rpm -qp --provides ../RPMS/noarch/perl-List-UtilsBy-0.06-1.fc14.noarch.rpm perl-List-UtilsBy = 0.06-1.fc14 "rpm -qp --provides" ... -p is a positional argument which takes one argument. Git done (by process-git-requests). (In reply to comment #5) > Same for a local f15 built: > > # rpm -q --provides -p > /var/lib/mock/fedora-rawhide-i386/result/perl-List-UtilsBy-0.06-1.fc15.noarch.rpm > perl(List::UtilsBy) = 0.06 > perl-List-UtilsBy = 0.06-1.fc15 > > Could it be you simply didn't specify the arguments in your rpmquery call > correctly? > > Note what you wrote in comment #1: > rpm -qp --provides ../RPMS/noarch/perl-List-UtilsBy-0.06-1.fc14.noarch.rpm > perl-List-UtilsBy = 0.06-1.fc14 > > > "rpm -qp --provides" ... -p is a positional argument which takes one argument. Ok, I had old testing rpm, which has troubles with creating correct provides. perl-List-UtilsBy-0.06-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-List-UtilsBy-0.06-1.fc13 perl-List-UtilsBy-0.06-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-List-UtilsBy-0.06-1.fc14 perl-List-UtilsBy-0.06-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-List-UtilsBy'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-List-UtilsBy-0.06-1.fc14 perl-List-UtilsBy-0.06-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. perl-List-UtilsBy-0.06-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |