Bug 667643

Summary: Regression: libvirt fails to add dhcp-hostsfile to dnsmasq command for static host entries
Product: [Community] Virtualization Tools Reporter: Neil Wilson <neil>
Component: libvirtAssignee: Daniel Veillard <veillard>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: low    
Version: unspecifiedCC: bugzilla, crobinso, jdenemar, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-06 15:11:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Neil Wilson 2011-01-06 10:51:13 UTC 
Description of problem:

https://bugzilla.redhat.com/show_bug.cgi?id=597363 introduced static only DHCP configuration into libvirt.

The 0.8.7 release has broken that functionality. It is no longer adding a 'dhcp-hostsfile' entry to the dnsmasq command. 

Now you get dnsmasq-dhcp[31621]: DHCPDISCOVER(brd706ea) 02:24:19:d7:06:ea no address available


Version-Release number of selected component (if applicable):

libvirt 0.8.7

How reproducible:

Create a static DHCP entry as described in https://bugzilla.redhat.com/show_bug.cgi?id=597363

 
Actual results:

dnsmasq-dhcp[31621]: DHCPDISCOVER(brd706ea) 02:24:19:d7:06:ea no address available


Expected results:

Address should be allocated.


Additional info:
Comment 1 Jiri Denemark 2011-01-06 15:11:19 UTC 
Should be fixed now in git by v0.8.7-9-ga43c733:

commit a43c7338d8772aa3a5bc0ec5914d3c28c20447c3
Author: Kay Schubert <kayegypt>
Date:   Thu Jan 6 09:14:58 2011 +0100

    bridge: Fix generation of dnsmasq's --dhcp-hostsfile option
    
    I added a host definition to a network definition:
    
    <network>
      <name>Lokal</name>
      <uuid>2074f379-b82c-423f-9ada-305d8088daaa</uuid>
      <bridge name='virbr1' stp='on' delay='0' />
      <ip address='192.168.180.1' netmask='255.255.255.0'>
        <dhcp>
          <range start='192.168.180.128' end='192.168.180.254' />
          <host mac='23:74:00:03:42:02' name='somevm' ip='192.168.180.10' />
        </dhcp>
      </ip>
    </network>
    
    But due to the wrong if-statement the argument --dhcp-hostsfile doesn't get
    added to the dnsmasq command. The patch below fixes it for me.
Comment 2 Jiri Denemark 2011-01-17 13:40:59 UTC 
*** Bug 670028 has been marked as a duplicate of this bug. ***