Bug 668222
Summary: | cleanup_on_success from config not honored | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
Component: | mock | Assignee: | Clark Williams <williams> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 14 | CC: | bochecha, dcantrell, fedora, lfarkas, mebrown, mikem, williams | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | mock-1.1.10-1.el6 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-05-19 04:38:49 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
some additional patches were submitted here: https://fedorahosted.org/mock/ticket/12 Another issue linked with this one : $ mock -r someconfig rebuild foo.src.rpm bar.src.rpm ERROR: Must specify --resultdir when building multiple RPMS. This error shouldn't be raised when resuldir is set in config file. Sorry about the duplication in the mock BTS, I thought that patches to the Git HEAD would be more appropriate over there. Any comments on the patches? Mathieu, I like the way that Remi solved the resultdir+cleanup issue, since he just used the Python 'in' operator. I will pull in the second and third patches though. Mathieu patch (even if a little heavy) works well (I'm using it for a few days), while mine doesn't handle all cases This cases should be accepted as result in distinct tree (refused by my "too much trivial" patch): basedir=/tmp resultdir=/var/tmp basedir=/var/lib/mock resultdir=/var/lib/mock/result Remi, Ok, we can pull bits from both :) (In reply to comment #4) > Mathieu, > > I like the way that Remi solved the resultdir+cleanup issue, since he just used > the Python 'in' operator. As long as we don't expect Mock to run on non-Unix platforms where Python runs that's fine. And as long as Linux doesn't change its path separator, but that's very unlikely in the near future. :) As Remi said, the only thing that really matters it that the test for "should we force not clearing the root dir" must be "is the result dir inside the root dir?". The rest is just an implementation detail. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. does any solution to this bug already applied to the git? I went back and added Mathieu's patchset since it does cover a more complete patcheset. Look in my 'work' branch of git for what I've done. queued for 1.1.10/1.0.17 build which should appear in testing next week. would it be possible to revert also the way as mock shows the missing dependency packages. fedore 1.1.9 it shows all missing package but now only show the first missing one. imho the old root log file was more useful. thanks. (In reply to comment #11) > would it be possible to revert also the way as mock shows the missing > dependency packages. fedore 1.1.9 it shows all missing package but now only > show the first missing one. imho the old root log file was more useful. > thanks. Hmmm, I don't think we changed anything that *should* affect the error output. Would you post the output you liked and what it is now so I can track down what section of code generates it? mock-1.1.10-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc15 mock-1.1.10-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc14 mock-1.0.17-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.17-1.el5 mock-1.1.10-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc13 mock-1.1.10-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.10-1.el6 Package mock-1.1.10-1.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing mock-1.1.10-1.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/mock-1.1.10-1.el6 then log in and leave karma (feedback). mock-1.1.10-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. (In reply to comment #12) > (In reply to comment #11) > > would it be possible to revert also the way as mock shows the missing > > dependency packages. fedore 1.1.9 it shows all missing package but now only > > show the first missing one. imho the old root log file was more useful. > > thanks. > > Hmmm, I don't think we changed anything that *should* affect the error output. > Would you post the output you liked and what it is now so I can track down what > section of code generates it? just make any rpm which has more than one BuildRequires and try to build in mock. now only one missing packages shown. mock-1.0.17-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. mock-1.1.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 472404 [details] mock.patch Description of problem: cleanup_on_success from config not honored From config: config_opts['basedir'] = '/dev/shm/' config_opts['resultdir'] = "/var/lib/mock/result" config_opts['cleanup_on_success'] = True Version-Release number of selected component (if applicable): 1.1.7-1.fc14 Additional info: The check done in cleanup_on_success erased this option, even if resultdir is separated from basedir. The simple attached patch seems to work (could be improved, because it test basedir instead of basedir/root) but my python skill are really limited.