Bug 669118

Summary: HTTP requests failing with Request header field is missing ':' separator.
Product: [Fedora] Fedora Reporter: Adam Young <ayoung>
Component: mod_nssAssignee: Rob Crittenden <rcritten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: low    
Version: 14CC: rcritten, sgallagh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: mod_nss-1.0.8-10.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-21 22:59:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 682326, 749401    
Attachments:
Description Flags
Patch for mod_nss overlapping memcpy none

Description Adam Young 2011-01-12 18:02:18 UTC 
Description of problem:

On FreeeIPA, which is using mod_nss, multiple requests fail with the error

HTTP requests failing with Request header field is missing ':' separator.

This is similar to the apache upstream issue:
https://issues.apache.org/bugzilla/show_bug.cgi?id=45444

mod_nss has the same issue.  A quick test seems to show that applying the patch from mod_ssl fixes the issue.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Install FreeIPA
2.Visit https://$(hostname)/ipa/ui/
  

Actual results:

Screen fails to render
Firebug Mozilla plugin shows that many of the requests have error message seen above.


Expected results:

ipa landing screen.
Additional info:
Comment 1 Stephen Gallagher 2011-01-12 18:04:50 UTC 
Created attachment 473094 [details]
Patch for mod_nss overlapping memcpy

This is modified from the mod_ssl version to apply to mod_nss. It converts the use of memcpy() here to memmove(), which is safe for buffers in which the destination and source overlap.
Comment 2 Stephen Gallagher 2011-01-12 18:07:05 UTC 
A little background information on this issue. In versions of glibc 2.12 and older, memcpy() was coincidentally safe for overlapping buffers. However, in the 2.13 development phase, the underlying algorithm for memcpy() changed and is no longer safe.

As the specification for memcpy() explicitly states, its results for overlapping buffers are undefined. The fact that it actually worked in older glibc was coincidental, but not supported.
Comment 3 Fedora Update System 2011-01-12 18:58:18 UTC 
mod_nss-1.0.8-10.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/mod_nss-1.0.8-10.fc14
Comment 4 Fedora Update System 2011-01-13 23:30:54 UTC 
mod_nss-1.0.8-10.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mod_nss'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/mod_nss-1.0.8-10.fc14
Comment 5 Fedora Update System 2011-01-21 22:59:47 UTC 
mod_nss-1.0.8-10.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.