Bug 669251
| Summary: | rtorrent fails to announce to invalid https trackers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Guest <quiffman> | ||||||||
| Component: | rtorrent | Assignee: | Conrad Meyer <cse.cem+redhatbugz> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | 13 | CC: | cse.cem+redhatbugz, sanjay.ankur | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-05-27 00:29:24 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Richard Guest
2011-01-13 01:49:55 UTC
I'm happy to take a patch, but I don't see one here or on the upstream tracker. Can you post it? Thanks! Created attachment 473191 [details]
rtorrent insecure https patch
Apologies for earlier attachment fail.
Created attachment 473198 [details]
patch for rtorrent-0.8.7
rtorrent-0.8.7 does the command line parsing slightly differently.
This patch should do the trick.
Thanks. Applied in rawhide, built in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2718382 I think we should be fine pushing this to released branches as well, assuming they're on 0.8.7 as well. Er, patch didn't apply cleanly. Will try to sort it out. Hmmm... I didn't do a very good job generating the patch, which may have caused it to get munged somewhere along the way. The attached patch is against three files, but the build in koji has attempted to patch just the first file. Created attachment 473424 [details]
A less munged patch against 0.8.7
Patching the following files:
rtorrent-0.8.7/src/command_network.cc
rtorrent-0.8.7/src/core/curl_stack.cc
rtorrent-0.8.7/src/main.cc
New patch seems to work fine. http://koji.fedoraproject.org/koji/taskinfo?taskID=2722463 rtorrent-0.8.7-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rtorrent-0.8.7-4.fc14 rtorrent-0.8.7-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Hi Richard, We've bumped to rtorrent 0.8.8 in rawhide and plan to push it to F-15 and F-14 as well; however, your https_insecure patch against 0.8.7 no longer applies against 0.8.8. If you still want this functionality, is there any chance you can update it to apply to 0.8.8? Otherwise we'll just drop it, sorry. Thanks for the heads up Conrad - don't be sorry, it was only intended as a stop-gap measure. The upstream bug is closed:fixed http://libtorrent.rakshasa.no/ticket/1402 Looking at the source, there appears to be an option network.http.ssl_verify_peer which will do the same thing. Either ack -i or grep -ir for ssl_verify in src should show you similar lines to what I submitted in that patch. I haven't had time to build and test the upstream changes, but I'm fairly certain it will have the same effect. Feel free to close this ticket.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
?GoAheadAndLogIn=1
Hmmm. Bit of a balls up trying to submit that comment while Bugzilla was down for upgrades... Sorry about that! Deleted Technical Notes Contents. Old Contents: ?GoAheadAndLogIn=1 Ah, great. Ok, I won't worry about it then =). |