Bug 669347

Summary:	Review Request: colord - Color daemon
Product:	[Fedora] Fedora	Reporter:	Richard Hughes <rhughes>
Component:	Package Review	Assignee:	Yanko Kaneti <yaneti>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, yaneti
Target Milestone:	---	Flags:	yaneti: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-01-13 18:24:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard Hughes 2011-01-13 12:55:05 UTC

Spec URL: http://people.freedesktop.org/~hughsient/temp/colord.spec
SRPM URL: http://people.freedesktop.org/~hughsient/temp/colord-0.1.0-1.fc15.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2718893
Description: colord is a low level system activated daemon that maps color devices to color profiles in the system context. It will be used by GNOME Color Manager and CUPS to enable the color management of printers.

[hughsie@localhost SPECS]$ rpmlint colord.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[hughsie@localhost SRPMS]$ rpmlint colord-0.1.0-1.fc15.src.rpm 
colord.src: W: non-standard-group Unspecified
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[hughsie@localhost RPMS]$ rpmlint colord-0.1.0-1.fc15.i686.rpm 
colord.i686: W: non-standard-group Unspecified
colord.i686: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.ColorManager.conf
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Note: if you're testing the CUPS integration, you need to use CUPS in rawhide with the enable-icc option turned on, or use http://gitorious.org/cups-colord/master/trees/master/doc and build from source.

I'll be adding the support in gnome-color-manager git master to use colord as a compile option in the next few weeks, but wanted rawhide to be in a position where people can try the new code early.

If you have any questions, I'm normally in IRC, nick: hughsie.

Thanks,

Richard.

Comment 1 Yanko Kaneti 2011-01-13 15:08:56 UTC

Source matches.
License matches.

No crazy binaries, permissions etc.

The group rpmlint warning is not valid for F14 and up.. (apparently)

Builds in mock. Installs quietly. Works as far the daemon starts when trying to use colormgr.

APPROVED

Comment 2 Richard Hughes 2011-01-13 15:20:04 UTC

New Package SCM Request
=======================
Package Name: colord
Short Description: Color daemon
Owners: rhughes
Branches: f14
InitialCC: rhughes

Comment 3 Jason Tibbitts 2011-01-13 15:24:56 UTC

FYI, install the package and run "rpmlint colord" and you'll see:

colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0 /lib64/libgmodule-2.0.so.0
colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0 /lib64/libgthread-2.0.so.0
colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0 /lib64/librt.so.1
colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0 /lib64/libpthread.so.0

Comment 4 Yanko Kaneti 2011-01-13 15:35:04 UTC

Ok, sorry. That part of the rpmlint course is new for me.
But many existing g* packages are giving me the same warning. Whats up here..

Comment 5 Yanko Kaneti 2011-01-13 15:55:52 UTC

Thanks for the pointer on irc

hughsie: please be advised to add the reccommened workaround from here before importing:
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency

Given how prevalent this issues is amongst the gnome stack I don't think it should block the importing of the package for now.

Comment 6 Richard Hughes 2011-01-13 15:59:59 UTC

(In reply to comment #3)
> FYI, install the package and run "rpmlint colord" and you'll see:
> 
> colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0
> /lib64/libgmodule-2.0.so.0
> colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0
> /lib64/libgthread-2.0.so.0
> colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0
> /lib64/librt.so.1
> colord.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcolord.so.1.0.0
> /lib64/libpthread.so.0

I didn't know you could do that either :-)

I'm pretty sure this should be fixed by changing the glib pc file to include things like librt -- it would be pretty odd for each leaf project to have to include stuff glib links to.

Comment 7 Jason Tibbitts 2011-01-13 17:26:25 UTC

Git done (by process-git-requests).

Comment 8 Richard Hughes 2011-01-13 18:24:28 UTC

Great, thanks guys!