| Summary: | No expected error prompt when compress guest core dump to invalid format | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | zhanghaiyan <yoyzhang> |
| Component: | libvirt | Assignee: | Osier Yang <jyang> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 6.1 | CC: | dallan, dyuan, eblake, jyang, llim, rwu, xen-maint, yupzhang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-0.9.4-rc2-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-06 10:53:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
zhanghaiyan
2011-01-14 03:38:11 UTC
http://www.redhat.com/archives/libvir-list/2011-January/msg00715.html patch acked by upstream. Hmm. Upstream commit 1b6f13bb7002d intentionally chose the behavior of falling back to raw if the compression type was invalid, because the thought was that in the event of a crash, it was more important to get a dump produced in some form than to fail because of a mis-configuration. In other words, I can't help but wonder if this bug should be closed as WONTFIX, because the behavior is intentional.
commit 1b6f13bb7002da76db15242e1d996e8a6222a754
Author: Hu Tao <hutao.com>
Date: Tue Nov 30 15:12:54 2010 +0800
Fall back to QEMUD_SAVE_FORMAT_RAW if compression method fails.
When dumping a domain, it's reasonable to save dump-file in raw format
if dump format is misconfigured or the corresponding compress program
is not available rather then fail dumping.
<snip> because the thought was that in the event of a crash, it was more important to get a dump produced in some form than to fail because of a mis-configuration. </snip> Yeah, I didn't realize this, the patch made by Hu Tao is helpful, but anyway, the error report statements should be improved, even use "VIR_WARN" is better than using "qemuReportError", isn't it? otherwise user will never known what happened, If no problem, I'd like make a new patch. v2 patch posted to upstream: http://www.redhat.com/archives/libvir-list/2011-January/msg00990.html Since RHEL 6.1 External Beta has begun, and this bug remains unresolved, it has been rejected as it is not proposed as exception or blocker. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. Osier, what happened with that patch, did we ever decide what to do with it? commit 01e1ea1219d50d188a526880b9d4dd9babc7bfa1
Author: Osier Yang <jyang>
Date: Thu Jul 28 09:37:52 2011 +0800
qemu: Improve docs for virsh dump format
The error in getCompressionType will never be reported, change
the errors codes into warning (VIR_WARN("%s", _(foo)); doesn't break
syntax-check rule), and also improve the docs in qemu.conf to tell
user the truth.
Patch commited to upstream.
Verified this with with kernel-2.6.32-172.el6.x86_64 qemu-kvm-0.12.1.2-2.172.el6.x86_64 libvirt-0.9.4-0rc2.el6.x86_64 Steps: 1.Add the following line in /etc/libvirt/qemu.conf # dump_image_format = "raw" dump_image_format = "123" 2. # service libvirtd restart 3.# virsh dump test test.123 Domain test dumped to test.123 4.# qemu-img info test.123 image: test.123 file format: raw virtual size: 282M (295681024 bytes) disk size: 282M In log file /var/log/libvirt/libvirtd.log,the warning message: 06:44:21.882: 8723: warning : getCompressionType:2737 : Invalid dump image format specified in configuration file, using raw In /etc/libvirt/qemu.conf file: # dump_image_format is used when you use 'virsh dump' at emergency # crashdump, and if the specified dump_image_format is not valid, or # the requested compression program can't be found, this falls # back to "raw" compression. So change the status to VERIFIED. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1513.html |