Bug 669638
| Summary: | %_smp_mflags enforces a limit of 16 CPUs | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Jon Masters <jcm> | |
| Component: | redhat-rpm-config | Assignee: | Panu Matilainen <pmatilai> | |
| Status: | CLOSED ERRATA | QA Contact: | Michal Trunecka <mtruneck> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 6.0 | CC: | dgilmore, ebenes, ffesti, omoris | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 905552 (view as bug list) | Environment: | ||
| Last Closed: | 2013-02-21 10:57:57 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 682670, 905552 | |||
I consider this worth fixing in RHEL6.1. I get the Fedora arguments, but I don't think they apply to RHEL. Reassigning back to reporter as Jon is handling the r-r-c errata for 6.1... As for the issue itself, I fail to see why any issues here in Fedora would not be applicaple to RHEL as well... but we're not going to find out by speculating. I'm planning just to remove the 16 limit. This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative. Reconsider for 6.3. Not at all urgent. the reason that I added the 16 cpu limit was becase on the fedora sparc builders we were getting build failures where objects would be built out of order with -j32 limiting to 24 did not help it was only when dropped to 16 that we did not see issues. its likely make bugs that were to blame. but building and linking as few as 2 objects could get messed up. ive been meaning to add a %_max_smp_mflags macro that would let a developer fully utilise all available cores. Mmh... how about macroizing the actual limit instead? Something like (untested):
%_smp_ncpus_max 16
%_smp_mflags %([ -z "$RPM_BUILD_NCPUS" ] \\\
&& RPM_BUILD_NCPUS="`/usr/bin/getconf _NPROCESSORS_ONLN`"; \\\
if [ "$RPM_BUILD_NCPUS" -gt %{_smp_ncpus_max} ]; then echo "-j%{_smp_ncpus_max}"; \\\
elif [ "$RPM_BUILD_NCPUS" -gt 1 ]; then echo "-j$RPM_BUILD_NCPUS"; fi)
That way the limit is overridable on per-system and per-user basis without having to change the specs, and also overridable within a spec.
Shrug... devel_ack, I'll add something similar to the above example. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0460.html |
Description of problem: You'll notice in the kernel SPEC file that BuildKernel does: make -s ARCH=$Arch V=1 %{?_smp_mflags} $MakeTarget %{?sparse_mflags} The value of %smp_mflags is determined (correctly) per architecture in /usr/lib/rpm/platform/arch-linux/macros by calling e.g.: /usr/bin/getconf _NPROCESSORS_ONLN However, then, the top level redhat-rpm-config provided macros override this with the following: %_smp_mflags %([ -z "$RPM_BUILD_NCPUS" ] \\\ && RPM_BUILD_NCPUS="`/usr/bin/getconf _NPROCESSORS_ONLN`"; \\\ if [ "$RPM_BUILD_NCPUS" -gt 16 ]; then echo "-j16"; \\\ elif [ "$RPM_BUILD_NCPUS" -gt 1 ]; then echo "-j $RPM_BUILD_NCPUS"; fi) So you can never have greater than -j16. Does anyone know if there's a reason for this, or is it something we want to get urgently fixed? Jon.