| Summary: | Review Request: perl-Test-Inter - Framework for more readable interactive test scripts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-18 08:19:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 669619 | ||
|
Description
Marcela Mašláňová
2011-01-14 09:25:27 UTC
+ source files match upstream.
445166a7472e609b96e4474d95552827 Test-Inter-1.01.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
(but needs a space after the period in 3rd line)
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=2720826
+ package installs properly.
+ rpmlint has no complaints:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(Test::Inter) = 1.01
perl-Test-Inter = 1.01-1.fc15
=
perl >= 0:5.004
perl(File::Basename)
perl(File::Basename)
perl(IO::File)
perl(IO::File)
perl(:MODULE_COMPAT_5.12.2)
perl(strict)
perl(vars)
perl(warnings)
+ %check is present and all tests pass.
+ ./Build test
t/file.t .......... ok
t/is.t ............ ok
t/ok.t ............ ok
t/pod.t ........... ok
t/pod_coverage.t .. ok
t/require_ok.t .... ok
t/skip_all.t ...... skipped: testing skip_all
t/tests.t ......... ok
t/use_ok.1.t ...... ok
t/use_ok.2.t ...... ok
t/use_ok.3.t ...... ok
All tests successful.
Files=11, Tests=60, 0 wallclock secs ( 0.03 usr 0.02 sys + 0.34 cusr 0.06 csys = 0.45 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
There's a space missing after the period in 3rd line of %description. And the explicit Requires for perl(File::Basename) and perl(IO::File) are unnecessary - both are detected automatically.
APPROVED.
Thank, I'll fix it. New Package SCM Request ======================= Package Name: perl-Test-Inter Short Description: Framework for more readable interactive test scripts Owners: mmaslano psabata ppisar Branches: F-13 InitialCC: perl-sig I guess this package was formerly orphaned/retired? https://admin.fedoraproject.org/pkgdb/acls/name/perl-Test-Inter Then you should use a "Package Change Request". You don't want an f14 branch? That still doesn't explain: http://koji.fedoraproject.org/koji/packageinfo?packageID=perl-Test-Inter Hm, looks like this is duplicate of 633879. Sorry for useless review :( *** This bug has been marked as a duplicate of bug 633879 *** |