| Summary: | Review Request: mediawiki116-ParserFunctions - Enhances the Mediawiki parser with logical functions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Weller <ian> |
| Component: | Package Review | Assignee: | Jon Stanley <jonstanley> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jonstanley, notting |
| Target Milestone: | --- | Flags: | jonstanley:
fedora-review+
notting: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-05-21 22:21:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 670035 | ||
|
Description
Ian Weller
2011-01-16 00:40:24 UTC
This package generally looks fine to me. A few nits: * License tag is GPLv2+ - upstream is absolutely insane and says on their website that the code is licensed under "GPL2 or any OSI approved license". This cannot possibly be true, as it uses MediaWiki API's. Looking in the COPYING file included in Subversion, however, this provision isn't in there - it's a copy of GPLv2 with a note that the extension may be distributed under the GNU General Public License: The ParserFunctions extension may be copied and redistributed under the GNU General Public License. So this in the source control would make sense, except that this cannot possibly be GPL+ either (which this language would indicate). In the end, I think that the license tag of GPL2 would probably work, as this is the only possible license that one could use this under. * Sources match upstream * License file is in package * Clean buildroot * Checkout instructions from upstream SCM included * Rpmlint clean With the license tag change, this package is APPROVED. New Package SCM Request ======================= Package Name: mediawiki116-ParserFunctions Short Description: Enhances the MediaWiki parser with logical functions Owners: ianweller Branches: el4 el5 el6 InitialCC: Git done (by process-git-requests). |