Bug 670082

Summary: asciitopgm memory corruption on too-long lines; doesn't handle blank lines
Product: [Fedora] Fedora Reporter: Jonathan Kamens <jik>
Component: netpbmAssignee: Jindrich Novy <jnovy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: jnovy, pknirsch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: netpbm-10.47.25-1.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-17 07:57:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to fix bugs
none
corrected patch to fix bugs none

Description Jonathan Kamens 2011-01-17 06:26:07 UTC
Created attachment 473765 [details]
patch to fix bugs

The asciitopgm program corrupts memory if any of the lines in its input text file are longer than the number of columns specified on the command line.

In addition, blank lines are not handled properly in the output pgm, with the result that the text looks denser in the pgm than it actually is.

The attached patch fixes both of these issues.

Comment 1 Jonathan Kamens 2011-01-17 06:27:37 UTC
Bugs reported and patch submitted to bryanh, as per bug submission instructions in netpbm sourceforge home page.

Comment 2 Jonathan Kamens 2011-01-17 06:32:42 UTC
Created attachment 473766 [details]
corrected patch to fix bugs

Woops, I left some debug code in. Here's a corrected patch.

Comment 3 Jindrich Novy 2011-01-17 07:57:11 UTC
Thanks! I updated to netpbm-10.47.25 and added your patch there as well.

Comment 4 Fedora Update System 2011-01-18 11:30:55 UTC
netpbm-10.47.25-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/netpbm-10.47.25-1.fc14

Comment 5 Fedora Update System 2011-01-18 11:31:56 UTC
netpbm-10.47.25-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/netpbm-10.47.25-1.fc13

Comment 6 Fedora Update System 2011-01-26 20:56:39 UTC
netpbm-10.47.25-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2011-01-26 21:00:07 UTC
netpbm-10.47.25-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.