Bug 670202

Summary: [abrt] system-config-printer-1.2.95-4.fc15: system-config-printer.py:1473:rename_printer:AttributeError: 'GUI' object has no attribute 'printer'
Product: [Fedora] Fedora Reporter: Horst H. von Brand <vonbrand>
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 15CC: adrin.jalali, jpopelka, twaugh
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: abrt_hash:3138d9b6
Fixed In Version: system-config-printer-1.3.3-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-21 17:12:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace none

Description Horst H. von Brand 2011-01-17 14:36:10 UTC
abrt version: 1.1.14
architecture: x86_64
cmdline: /usr/bin/python /usr/share/system-config-printer/system-config-printer.py
comment: See steps
component: system-config-printer
executable: /usr/share/system-config-printer/system-config-printer.py
kernel: 2.6.37-2.fc15.x86_64
package: system-config-printer-1.2.95-4.fc15
reason: system-config-printer.py:1473:rename_printer:AttributeError: 'GUI' object has no attribute 'printer'
release: Fedora release 15 (Rawhide)
time: 1295274833
uid: 500

backtrace
-----
system-config-printer.py:1473:rename_printer:AttributeError: 'GUI' object has no attribute 'printer'

Traceback (most recent call last):
  File "/usr/share/system-config-printer/system-config-printer.py", line 1407, in printer_name_edited
    self.rename_printer (name, newname)
  File "/usr/share/system-config-printer/system-config-printer.py", line 1473, in rename_printer
    if not self.printer:
AttributeError: 'GUI' object has no attribute 'printer'

Local variables in innermost frame:
new_name: 'dcsc'
self: <GUI object at 0x18a4d20 (uninitialized at 0x0)>
rejecting: False
old_name: u'HP_HP_LaserJet_M1522nf_MFP'

How to reproduce
-----
1. Created a new printer via the CUPS page on localhost
2. Deleted (via Administration --> Printing) the printer dcsc
3. Tried to rename HP_HP_.... to dcsc, the new dcsc shows up but the HP_HP_... doesn't dissapear

Comment 1 Horst H. von Brand 2011-01-17 14:36:13 UTC
Created attachment 473853 [details]
File: backtrace

Comment 2 Horst H. von Brand 2011-01-17 14:57:45 UTC
After the above dance, the dcsc entry shows up OK, and I deleted the (after some further tweaking of dcsc) useless HP_HP_... entry.

Comment 3 Tim Waugh 2011-01-17 15:56:50 UTC
> self: <GUI object at 0x18a4d20 (uninitialized at 0x0)>

This is interesting.  I wonder how the GUI object would end up not initialised even though we're calling one of its methods?

Comment 4 Jiri Popelka 2011-01-17 16:05:40 UTC
Could be on one of duplicates of bug #589793 ?

Comment 5 Tim Waugh 2011-01-17 16:23:34 UTC
Possibly.  Tracebacks so far have had things like:

self: <__main__.GUI instance at 0x9d0c9cc>
self: <__main__.GUI instance at 0x93143ac>
self: <__main__.GUI instance at 0xa1e6d4c>
self: <__main__.GUI instance at 0x9b78bcc>
self: <__main__.GUI instance at 0x2670290>
self: <__main__.GUI instance at 0x24abc68>

This bug is the first time I've seen "(uninitialized at 0x0)".

Comment 6 Horst H. von Brand 2011-01-17 16:59:08 UTC
I had the Administration --> Printing thingy open while I futzed around with creating the printer via the CUPS webpage.

AFAIR, the sequence was:

- Open A --> P
- Open CUPS page, create new printer
- Go to A --> P, delete old dcsc printer
- Rename HP_... to dcsc

dcsc was the system default printer.

Comment 7 Tim Waugh 2011-01-17 17:25:33 UTC
Can you reproduce it at all?

Comment 8 Horst H. von Brand 2011-02-21 16:29:04 UTC
(In reply to comment #7)
> Can you reproduce it at all?

Not anymore (now system-config-printer-1.3.1-1.fc16.x86_64 here)

Comment 9 Tim Waugh 2011-02-21 16:42:56 UTC
OK, closing.

Comment 10 Tim Waugh 2011-05-13 10:05:50 UTC
*** Bug 700562 has been marked as a duplicate of this bug. ***

Comment 11 Tim Waugh 2011-05-17 16:01:59 UTC
Package: system-config-printer-1.3.2-2.fc15
Architecture: x86_64
OS Release: Fedora release 15 (Lovelock)


Comment
-----
Renamed a printer from "EPSON-Stylus-D78" to "Charlie".

Comment 12 Tim Waugh 2011-05-17 16:07:41 UTC
Wahey, finally saw this myself today.  I was renaming a printer that I had created using s-c-printer.  The printer was called EPSON-Stylus-D78, and I selected Rename from the right-click menu.  Then I entered "Charlie" and pressed enter.

The result is that I have a new queue 'Charlie', but the old queue 'EPSON-Stylus-D78' still exists (and is rejecting jobs).

It's repeatable.

Comment 13 Tim Waugh 2011-05-17 16:09:39 UTC
Fixed upstream in f7427c05d83d9d7f4b1385dee939920bcb02bd1f.

Comment 14 Fedora Update System 2011-06-03 11:34:44 UTC
system-config-printer-1.3.3-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/system-config-printer-1.3.3-1.fc15

Comment 15 Fedora Update System 2011-06-04 03:04:17 UTC
Package system-config-printer-1.3.3-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-printer-1.3.3-1.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/system-config-printer-1.3.3-1.fc15
then log in and leave karma (feedback).

Comment 16 Heiko Adams 2011-06-06 16:33:56 UTC
Package: system-config-printer-1.3.2-2.fc15
Architecture: i686
OS Release: Fedora release 15 (Lovelock)


Comment
-----
tried to rename a network printer

Comment 17 Fedora Update System 2011-06-21 17:12:25 UTC
system-config-printer-1.3.3-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.