Bug 670239

Summary:	jpeg messages encoding is transfered as 4 and not 1, breaking client
Product:	Red Hat Enterprise Linux 6	Reporter:	Alon Levy <alevy>
Component:	spice-server	Assignee:	Uri Lublin <uril>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	low
Version:	6.1	CC:	dblechte, hdegoede, lkocman, mhasko, mkenneth
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spice-server-0.7.2-2.el6	Doc Type:	Bug Fix
Doc Text:	JPEG message encoding was handled differently between client and server, such that the server passed the client a value to determine an image's orientation, which the client thought is invalid. This resulted in the client aborting. The value passed from the server is now the one the client expects, so the client no longer aborts.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 14:07:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	671385

Description Alon Levy 2011-01-17 16:25:31 UTC

Description of problem:
The header field sent in jpeg compressed images which specifies upside downness of the image is being inconsistently handled:
 * server sends 4 or 0
 * client ASSERTS it is 1 or 0
Results in client crash.

Upstream fix for server:
5c0873a server/red_worker: use 1, not 4 when lz_encoding a top down image

Make server send 1 or 0

Version-Release number of selected component (if applicable):
0.7.1

How reproducible:
Always

Steps to Reproduce:
1. start guest with jpeg enabled (force it so it doesn't require emulating a wan environment)
2. in windows guest toggling the start menu repeatedly trigers a jpeg image sent
3. watch client crash
  
Actual results:

Comment 2 Uri Lublin 2011-01-19 15:28:32 UTC

The commit upstream is 0438742dcc9fdf5f21afba1edc931632f51a55ed

Comment 3 Uri Lublin 2011-01-31 13:05:54 UTC

Fixed upstream in 2a9f35a98f4dabd8e1e0412d498907df3a04f71a

Comment 8 Laura Bailey 2011-04-20 06:54:55 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
JPEG message encoding was handled differently between client and server, such that the server passed the client an invalid value to determine an image's orientation. This resulted in the client crashing. The value passed from the server is now valid, so the crash no longer occurs.

Comment 9 Uri Lublin 2011-05-09 09:56:16 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-JPEG message encoding was handled differently between client and server, such that the server passed the client an invalid value to determine an image's orientation. This resulted in the client crashing. The value passed from the server is now valid, so the crash no longer occurs.+JPEG message encoding was handled differently between client and server, such that the server passed the client a value to determine an image's orientation, which the client thought is invalid. This resulted in the client aborting. The value passed from the server is now the one the client expects, so the client no longer aborts.

Comment 11 errata-xmlrpc 2011-05-19 14:07:42 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0705.html