Bug 670312

Summary:	Please add 'hal' to %requires
Product:	[Fedora] Fedora	Reporter:	James Laska <jlaska>
Component:	anaconda	Assignee:	Chris Lumens <clumens>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	anaconda-maint-list, jonathan, jturner, vanmeeuwen+fedora
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	anaconda-15.16-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-01-20 15:00:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description James Laska 2011-01-17 21:04:54 UTC

= Description =

When starting a rawhide live image, and running 'liveinst'

= Media tested =

http://alt.fedoraproject.org/pub/alt/nightly-composes/desktop/

= Steps to reproduce =

1. Boot live image
2. Login to desktop (if not auto-logged in)
3. From a terminal start the installer by typing: liveinst

= Actual Results =

liveinst fails to start anaconda because '/usr/bin/hal-lock' (provided by hal) is not present.  The 'hal' package is not installed 

= Expected Results =

After installing hal manually, the liveinst command successfully starts the live installer

Comment 1 Chris Lumens 2011-01-19 16:51:30 UTC

Does the following patch fix the problem without causing other programs to start up thinking that they should be managing disks?

--- a/data/liveinst/liveinst
+++ b/data/liveinst/liveinst
@@ -103,10 +103,8 @@ anaconda-cleanup $ANACONDA $*
 
 /sbin/udevadm control --env=ANACONDA=1
 
-if [ -x /usr/bin/devkit-disks ]; then
-    /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$A
-elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
-    /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
+if [ -x /usr/bin/udisks ]; then
+    /usr/bin/udisks --inhibit -- "$ANACONDA $*"
 else
     $ANACONDA $*
 fi

Comment 2 James Laska 2011-01-19 18:19:30 UTC

I think it works okay, but then anaconda hits a traceback for a different reason.

Traceback (most recent call last):
  File "/usr/bin/anaconda-cleanup", line 92, in <module>
    devicetree.populate(cleanupOnly=True)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 1679, in populate
    self._populate()
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 1726, in _populate
    self.addUdevDevice(dev)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 968, in addUdevDevice
    self.handleUdevDeviceFormat(info, device)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 1419, in handleUdevDeviceFormat
    self.handleUdevDiskLabelFormat(info, device)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 1053, in handleUdevDiskLabelFormat
    if initcb is not None and initcb():
  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 1045, in <lambda>
    details)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/installinterfacebase.py", line 82, in questionInitializeDisk
    rc = self.reinitializeWindow(_("Storage Device Warning"),
AttributeError: 'InstallInterface' object has no attribute 'reinitializeWindow'
Error launching program: Failed to execute child process "/usr/sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-osimg-min --lang en_US.UTF-8 " (No such file or directory)

Comment 3 Chris Lumens 2011-01-19 18:25:00 UTC

Okay, I'd consider that a separate bug.  I'll mail off the patch for the initial problem.

Comment 4 Chris Lumens 2011-01-20 15:00:12 UTC

The traceback in comment #2 has been fixed, and I've committed the original patch to remove use of hal-lock.