| Summary: | Review Request: perl-String-Similarity - Calculates the similarity of two strings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ruediger Landmann <rlandman> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-04 03:00:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Ruediger Landmann
2011-01-18 00:04:15 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
FIX - license field must match actual license - it's GPLv2+ if you look in source code
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
rpm -qp --provides perl-String-Similarity-1.04-1.fc15.i686.rpm
perl(String::Similarity) = 1.04
perl-String-Similarity = 1.04-1.fc15
perl-String-Similarity(x86-32) = 1.04-1.fc15
rpm -qp --requires perl-String-Similarity-1.04-1.fc15.i686.rpm
perl(:MODULE_COMPAT_5.12.2)
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1.3)
perl(DynaLoader)
perl(Exporter)
rpmlib(VersionedDependencies) <= 3.0.3-1
rtld(GNU_HASH)
Also you can remove rm -rf from build part.
Thanks for the review Marcela. I've updated the license to GPLv2+ and removed the unnecessary cleaning of the build root. New spec file: http://rlandmann.fedorapeople.org/packages/perl-String-Similarity.spec New SRPM: http://rlandmann.fedorapeople.org/packages/perl-String-Similarity-1.04-2.fc14.src.rpm Cheers Ruediger ACCEPT New Package SCM Request ======================= Package Name: perl-String-Similarity Short Description: Calculates the similarity of two strings Owners: rlandmann Branches: f13 f14 InitialCC: perl-sig Git done (by process-git-requests). Ping? Could you close it now? Closing review is a duty of reporter. Sorry Marcela! Closing... Package Change Request ====================== Package Name: perl-String-Similarity New Branches: el6 Owners: rlandmann Git done (by process-git-requests). |